8000 chore: v1.0.0 prep by sstadick · Pull Request #59 · sstadick/gzp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: v1.0.0 prep #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2025
Merged

chore: v1.0.0 prep #59

merged 4 commits into from
Feb 24, 2025

Conversation

sstadick
Copy link
Owner
  • chore: Upgrade all deps to latest
  • fix: Mitigate failures in core_affinity_rs
  • feat: Migrate to zlib-ng instead of zlib-ng-compat from @camlloyd PR
  • fix: non-libdeflate bgzf tests failing due to worse compression resulting in buffers larger than BGZF max.

camlloyd and others added 3 commits February 20, 2025 09:59
@camlloyd @sstadick
feat: migrate to zlib-ng (#54)
71a78db 
* docs: added link to i686-pc-windows-pc issue in features docs

* feat: migrate to `zlib-ng`

---------

Co-authored-by: Seth <sstadick@gmail.com>
@sstadick
fix: handle core_affinity not working
0846f3d
@sstadick
chore: fix cargo fmt changes
be82eb5
sstadick
sstadick commented Feb 20, 2025
View reviewed changes
src/par/compress.rs
@@ -96,7 +97,12 @@ where

/// Set the [`pin_threads`](ParCompressBuilder.pin_threads).
pub fn pin_threads(mut self, pin_threads: Option<usize>) -> Self {
self.pin_threads = pin_threads;
if core_affinity::get_core_ids().is_none() {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example checking this on the compress/decompress threads.

sstadick
sstadick commented Feb 20, 2025
View reviewed changes
src/par/decompress.rs
@@ -55,7 +56,12 @@ where

/// Set the [`pin_threads`](ParDecompressBuilder.pin_threads).
pub fn pin_threads(mut self, pin_threa 8000 ds: Option<usize>) -> Self {
self.pin_threads = pin_threads;
if core_affinity::get_core_ids().is_none() {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example in constructors, check this and setting it to None.

@0-wiz-0 0-wiz-0 mentioned this pull request Feb 21, 2025
Closed
@sstadick sstadick merged commit a234716 into main Feb 24, 2025
10 checks passed
@sstadick sstadick deleted the chore/v1.0.0_prep branch February 24, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sstadick @camlloyd
0