Tags: turbokernel/pipeline
Tags
Resolved result ref order can affect unit test outcome Test TestTaskParamResolver_ResolveResultRefs performs a diff on a slice of resolved result references. Unfortunately the ordering of this slice is not guaranteed so sometimes the test fails. This PR updates the unit test to check each entry appears as expected in the tt.want slice (confirming also that the lengths of the slices match). Also adds a small helper func to format the resolved result refs for printing in the event that they don't match.
Do not panic if Timeout is nil `TaskRun` and `PipelineRun` should have a default Timeout set by the webhook. That said, if the webhook didn't do its work, or the object where created before those webhook defaults, it could be nil and makes the controller panicking. Signed-off-by: Vincent Demeester <vdemeest@redhat.com> (cherry picked from commit 4cd1d52)
PreviousNext