8000 Support for every property by MartijnCuppens · Pull Request #144 · twbs/rfs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support for every property #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2019
Merged

Support for every property #144

merged 1 commit into from
Aug 28, 2019

Conversation

MartijnCuppens
Copy link
Member
@MartijnCuppens MartijnCuppens commented Jul 10, 2019 •
edited
Loading

So far RFS could be used to rescale font sizes, but with the new implementation other properties can also make use of rfs' rescaling mechanism.

Features

  • Support for all properties
  • Shorthand mixins for margins and paddings
  • Support for custom properties

Changes

  • Clearer way to declare !important rules: @include rfs(1rem !important) instead of @include rfs(1rem, true)
  • Switched to mobile first approach, still possible to switch to the max-width media queries if needed
  • px-values should always have a unit now. In v8, RFS assumed every unitless value was set in px (eg. @include rfs(32)), but since we can now pass numbers too (eg. @include rfs(1 1 30rem, flex), this behaviour is changed.
  • Configuration variables are changed:
    • Base font size → Base value
    • Font size unit → unit

PostCSS implementation change

Drops

  • Dropped responsive-font-size mixins
  • Dropped Less 2 support since we had to work with lists

Meta

  • Prevent generation of /test/expected/main.css
  • Additional tests for new implementations
  • Cleanup npm scripts examples
  • postcss-value-parser dependency added to parse values in PostCSS plugin.

Demos

TODOs

  • Clean up git
  • Update documentation
  • Check for outdated info
  • Link to example(s)
  • Use postcss-value-parser to parse values to prevent issues with nested functions (like calc() or rgba())
  • Document CSS Properties support
  • Expose rfsValue and rfsFluidValue functions so that they can be used by other js plugins or node applications

Fixes #116
Fixes #139
Fixes #154

@MartijnCuppens MartijnCuppens added the v9 Ideas for v9 label Jul 10, 2019
@MartijnCuppens MartijnCuppens force-pushed the v9 branch 4 times, most recently from 1dddade to 2e9940e Compare July 24, 2019 17:04
@MartijnCuppens MartijnCuppens force-pushed the v9 branch 4 times, most recently from 5eb406e to 5ee70a1 Compare July 25, 2019 20:28
@MartijnCuppens MartijnCuppens mentioned this pull request Jul 27, 2019
Closed
@MartijnCuppens MartijnCuppens requested a review from XhmikosR August 5, 2019 17:32
@MartijnCuppens
Copy link
Member Author

@XhmikosR, this one is ready for review. postcss-value-parser is added as dependency to parse values in postcss.

#150 should be merged first

@MartijnCuppens MartijnCuppens force-pushed the v9 branch 2 times, most recently from e394a68 to db69235 Compare August 8, 2019 19:10
@MartijnCuppens MartijnCuppens mentioned this pull request Aug 18, 2019
Closed
@MartijnCuppens MartijnCuppens force-pushed the v9 branch 3 times, most recently from b7b1e19 to 2c709f4 Compare August 23, 2019 14:50
XhmikosR
XhmikosR reviewed Aug 24, 2019
View reviewed changes
ysds
ysds reviewed Aug 27, 2019
View reviewed changes
@MartijnCuppens
Support for every property
f4896c1 
- Support for all properties
- Shorthand mixins for margins and paddings
- Support for custom properties
- Clearer way to declare `!important` rules: `@include rfs(1rem !important)` instead of `@include rfs(1rem, true)`
- Switched to mobile first approach, still possible to switch to the `max-width` media queries if needed
- Configuration variables are changed:
	- Base font size -> Base value
	- Font size unit -> Unit
- `responsive-font-size` property changed to `rfs()` function (see #116)
- Dropped `responsive-font-size` mixins
- Dropped Less 2 support since we had to work with lists
- Prevent generation of `/test/expected/main.css`
- Additional tests for new implementations
- Cleanup npm scripts examples
- Code examples in `README.md` are grouped by processor and collapsed
@MartijnCuppens MartijnCuppens merged commit 89f7a63 into master Aug 28, 2019
@MartijnCuppens MartijnCuppens deleted the v9 branch August 28, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR left review comments

@ysds ysds ysds approved these changes

Assignees
No one assigned
Labels
v9 Ideas for v9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix spaces before semicolon at set the calculated font-size part Using CSS variables with postCSS 3D96 Alternative PostCSS implementation
3 participants
@MartijnCuppens @XhmikosR @ysds
0