Load JSON and TOML grammars before tests in cli-testers.rs
#779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to prefetch JSON and TOML grammars before running the tests, on pain of race condition: If multiple calls to Topiary are made in parallel and the grammar is missing, they will all try to fetch and build it, thus creating an empty .so file while g++ is running. If another instance of Topiary starts at this moment, it will mistake the empty .so file for an already built grammar, and try to run with it, resulting in an error.
3091e22 to
77ae922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to prefetch JSON and TOML grammars before running the tests, on pain of race condition:
If multiple calls to Topiary are made in parallel and the grammar is missing, they will all try to fetch and build it, thus creating an empty
.sofile whileg++is running.If another instance of Topiary starts at this moment, it will mistake the empty
.sofile for an already built grammar, and try to run with it, resulting in an error.Closes #767
Checklist
Checklist before merging: