8000 Use `gix` lib instead of the `git` system install by nbacquey · Pull Request #893 · tweag/topiary · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use gix lib instead of the git system install #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Use gix lib instead of the git system install #893

merged 2 commits into from
Mar 10, 2025

Conversation

nbacquey
Copy link
Member
@nbacquey nbacquey commented Mar 4, 2025 •
edited
Loading

Closes #886

Description

This PR modifies the module that dynamically loads grammars from git repositories. We used to call the system's install of git (while never actually listing it as a dependency). Now we use gix instead, which removes that dependency while ensuring cross-platform compatibility with macOS.

Checklist

Checklist before merging, wherever relevant:

@nbacquey
Copy link
Member Author
nbacquey commented Mar 4, 2025

Will clean up later, I just want to run CI on this

@nbacquey nbacquey force-pushed the nb/gix branch 2 times, most recently from 18c8f27 to d2dad18 Compare March 5, 2025 13:55
@nbacquey nbacquey mentioned this pull request Mar 5, 2025
Closed
@nbacquey nbacquey force-pushed the nb/gix branch 3 times, most recently from d2536d2 to 3b3e3d7 Compare March 6, 2025 19:52
@nbacquey nbacquey changed the title WIP: try gix Use gix lib instead of the git system install Mar 6, 2025
@nbacquey nbacquey marked this pull request as ready for review March 6, 2025 20:06
@nbacquey nbacquey requested review from Xophmeister and yannham March 6, 2025 20:07
Xophmeister
Xophmeister approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member
@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙇

Does this still do the equivalent of a blobless clone?

@nbacquey
Copy link
Member Author

I don't think so; I wasn't able to find where to add that option

@nbacquey nbacquey merged commit 1879a6a into main Mar 10, 2025
10 checks passed
@nbacquey nbacquey deleted the nb/gix branch March 10, 2025 10:28
@BrewTestBot BrewTestBot mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xophmeister Xophmeister Xophmeister approved these changes

@yannham yannham Awaiting requested review from yannham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate gitoxide
2 participants
@nbacquey @Xophmeister
0