Fixed unhandled trailing comment in multiline list for OpenSCAD #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's causing the tests to fail, will look into it |
|
The output of the test is misleadingly verbose, but the actual failure is: i.e. the rule you wrote produced some idempotency error |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1ecb4c6 to
4525f8f
Compare
|
There still seem to be idempotency failures in the tests. I'll delay my review until they pass |
|
@nbacquey should be fixed |
|
@Xophmeister heads up, I've probably introduced the same issue in the WIT formatter with |
nbacquey
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unhandled trailing comment in multiline list for OpenSCAD
Resolves #969
Description
An extraneous trailing comma was previously added to a list if the trailing comma of a list was followed by a comment:
Checklist
Checklist before merging, wherever relevant:
CHANGELOG.mdupdatedREADME.md, etc.) up-to-date