Make main optional when compiling to WASM
#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure this is idiomatic. However, I noticed, that when compiling to e.g. a yew app, which has a `main`, it conflicts with the existing `main` from `kord`.
The double negation of `not("wasm_no_main")` is because I didn't want to make this a breaking change, which I guess a feature `"wasm_main"` would have been.
Let me know if you prefer a feature `"wasm_main"` as part of the `default-features` perhaps, or something else entirely.
|
Actually, I think the right thing to do idiomatically is to delete the |
|
Here's a variant without a Maybe a good compromise would be to simply keep the original What do you think? |
|
Yeah, I think we should remove them altogether. |
twitchax
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is idiomatic. However, I noticed, that when compiling to e.g. a yew app, which has a
main, it conflicts with the existingmainfromkord. The double negation ofnot("wasm_no_main")is because I didn't want to make this a breaking change, which I guess a feature"wasm_main"would have been. Let me know if you prefer a feature"wasm_main"as part of thedefault-featuresperhaps, or something else entirely.