typed-ember · machty · Mar 17, 2025 · Mar 12, 2025 · Mar 12, 2025 · Mar 17, 2025
diff --git a/.eslintignore b/.eslintignore
@@ -1,10 +1,6 @@
 # Compiled output
 /packages/*/lib
-/packages/scripts/bin
 /test-packages/*/lib
 
 dist/
 __fixtures__
-
-# Ephemeral test applications
-/test-packages/ephemeral
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -99,8 +99,6 @@ jobs:
   #         max_attempts: 2
   #         timeout_minutes: 10
   #         command: yarn workspace glint-vscode test
-  #     - name: Test @glint/scripts
-  #       run: yarn workspace @glint/scripts test
 
   # tracking for re-enablement here: https://github.com/typed-ember/glint/issues/728
   # test-floating-deps:

diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,5 @@
 node_modules
 yarn-error.log
-test-packages/ephemeral
 .eslintcache
 *.tsbuildinfo
 *.js.map

diff --git a/.prettierignore b/.prettierignore
@@ -1,12 +1,8 @@
 # Compiled output
 /packages/*/lib
 /test-packages/*/lib
-/packages/scripts/bin
 dist/
 
-# Ephemeral test applications
-/test-packages/ephemeral
-
 # Hidden directories
 .*/
 

diff --git a/packages/core/__tests__/cli/build.test.ts b/packages/core/__tests__/cli/build.test.ts
@@ -1,4 +1,4 @@
 import { afterEach, beforeEach, describe, expect, test } from 'vitest';

 test('maybe reinstate these tests');

@@ -36,7 +36,7 @@
       await project.destroy();
     });
 
-    test.only('passes a valid basic project', async () => {
+    test('passes a valid basic project', async () => {
       let code = stripIndent`
         import '@glint/environment-ember-template-imports';
         import Component from '@glimmer/component';

diff --git a/packages/core/__tests__/cli/check-watch.test.ts b/packages/core/__tests__/cli/check-watch.test.ts
@@ -1,3 +1,12 @@
+import { afterEach, beforeEach, describe, expect, test } from 'vitest';
+
+test('maybe reinstate these tests');
+
+/*
+Skipping all of this for now. Now that we've offloaded a lot of this logic to Volar
+this is an opportunity to rebuild the test suite to not re-test what Volar already
+tests.
+
 import * as os from 'node:os';
 import { stripIndent } from 'common-tags';
 import stripAnsi = require('strip-ansi');
@@ -385,3 +394,4 @@
     });
   });
 });
+*/
diff --git a/packages/core/__tests__/cli/check.test.ts b/packages/core/__tests__/cli/check.test.ts
@@ -1,3 +1,14 @@
+import { afterEach, beforeEach, describe, expect, test } from 'vitest';
+
+test('maybe reinstate these tests');
+
+/*
+Skipping all of this for now. Now that we've offloaded a lot of this logic to Volar
+this is an opportunity to rebuild the test suite to not re-test what Volar already
+tests.
+
+
+
 import { stripIndent } from 'common-tags';
 import stripAnsi = require('strip-ansi');
 import { describe, beforeEach, afterEach, test, expect } from 'vitest';
@@ -429,3 +440,4 @@ describe('CLI: single-pass typechecking', () => {
     `);
   });
 });
+*/
diff --git a/packages/core/__tests__/cli/declaration.test.ts b/packages/core/__tests__/cli/declaration.test.ts
@@ -1,3 +1,12 @@
+import { afterEach, beforeEach, describe, expect, test } from 'vitest';
+
+test('maybe reinstate these tests');
+
+/*
+Skipping all of this for now. Now that we've offloaded a lot of this logic to Volar
+this is an opportunity to rebuild the test suite to not re-test what Volar already
+tests.
+
 import { stripIndent } from 'common-tags';
 import { describe, beforeEach, afterEach, test, expect } from 'vitest';
 import { Project, BASE_TS_CONFIG } from 'glint-monorepo-test-utils';
@@ -137,3 +146,4 @@ describe('CLI: emitting declarations', () => {
     `);
   });
 });
+*/
diff --git a/packages/core/__tests__/language-server/symbol-search.test.ts b/packages/core/__tests__/language-server/symbol-search.test.ts
diff --git a/packages/core/src/language-server/messages.cts b/packages/core/src/language-server/messages.cts
diff --git a/packages/core/src/language-server/util/index.ts b/packages/core/src/language-server/util/index.ts
@@ -1,15 +0,0 @@
-export { positionToOffset, offsetToPosition } from './position.js';
-
-import { URI } from 'vscode-uri';
-
-export function uriToFilePath(uri: string): string {
-  return URI.parse(uri).fsPath.replace(/\\/g, '/');
-}
-
-export function filePathToUri(filePath: string): string {
-  return URI.file(filePath).toString();
-}
-
-export function normalizeFilePath(filePath: string): string {
-  return uriToFilePath(filePathToUri(filePath));
-}

diff --git a/packages/core/src/language-server/util/position.ts b/packages/core/src/language-server/util/position.ts
diff --git a/packages/core/src/language-server/util/previewer.ts b/packages/core/src/language-server/util/previewer.ts
diff --git a/packages/scripts/.gitignore b/packages/scripts/.gitignore