Fix VSCode extension pre-release #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machty
commented
Mar 23, 2025
| @@ -14,7 +14,7 @@ | |||
| ] | |||
| }, | |||
| "scripts": { | |||
| "reset": " git clean -Xfd; git clean -fd; pnpm i && pnpm build", | |||
| "reset": "git clean -Xfd; git clean -fd; pnpm i && pnpm build > /dev/null 2>&1; pnpm i -f; pnpm build; pnpm sync", | |||
There was a problem hiding this comment.
@NullVoxPopuli had to reinstate your original reset script (main is broken without this fix too)
There was a problem hiding this comment.
Hmm sus. I'll investigate
machty
commented
Mar 23, 2025
| "enableForWorkspaceTypeScriptVersions": true, | ||
| "languages": [ | ||
| "glimmer-ts", | ||
| "glimmer-js" | ||
| "glimmer-js", | ||
| "handlebars" |
There was a problem hiding this comment.
This declaration fixes the ts+hbs loose mode vscode test on main failing; I'm guessing some new VSCode bumped its inner node runtime to something that disallows monkeypatching the fs module (see other comment), so our monkey patched code to pass in handlebars via a value read from VSCode preferences no longer works (which is where we were supplying handlebars, so we have to provide it here).
| @@ -234,6 +232,10 @@ try { | |||
|
|
|||
| const languageIdsQuoted = config.server.includeLanguages.map((lang) => `'${lang}'`).join(','); | |||
|
|
|||
| // TODO: as of March 23 2025 and perhaps a few days before, this fs.readFileSync hacky | |||
| // is failing with "Cannot set property readFileSync of #<Object> which has only a getter". | |||
| // Stay tuned for another hack from Volar... or hopefully an upstream fix from VSCode. | |||
There was a problem hiding this comment.
This is the no-longer-working hack described above.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of eslint and vsce tweaks to properly bundle the dependencies needed for pre-release Glint to work when downloaded from the VSCode marketplace.
Example of Glint in new TS Plugin mode kicking in in VSCode (.gts file):
Example of Glint in new TS Plugin mode kicking in in VSCode (.hbs file):
Version 1.4.3 available in VSCode marketplace for pre-release download.