24 implement joke command make it good look with loading indicator #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error handling - Added a loading spinner while fetchi 8000 ng jokes to enhance user experience. - Implemented a timeout for the HTTP client to prevent hanging requests. - Improved error messages for various failure scenarios during joke retrieval. - Updated success message formatting for better visibility of the fetched joke.
…ture - Introduced a separate fetchJoke function to encapsulate API request logic. - Enhanced error messages for better clarity on failure scenarios. - Updated success message formatting for improved visibility of fetched jokes. - Added constants for API endpoint and request timeout for better maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.