8000 Fix typos by anton-trunov · Pull Request #372 · tact-lang/tact · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typos #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 3, 2024
Merged

Fix typos #372

merged 5 commits into from
Jun 3, 2024

Conversation

anton-trunov
Copy link
Member
@anton-trunov anton-trunov commented Jun 3, 2024 •
edited
Loading

Closes #310

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov
fix: typos in comments and identifiers
83e61d9
@anton-trunov
fix(abi): undeflow -> underflow
f36e34a 
The reason addresses are changed in snapshots is because
the generated FunC code got changed too because
`get_abi_ipfs` getters are now containing different
IPFS addresses due to changed ABIs:

```
_ get_abi_ipfs() method_id {
    return "ipfs://QmRM77XpqMrANwLE8K3A287jZHvuQSLr76xYM2ea8wZZ89";
//                 ^^^ the hash changes
}
```
@anton-trunov
ci: add spell checking with cSpell
7289b0e
@anton-trunov anton-trunov added this to the v1.3.1 milestone Jun 3, 2024
@anton-trunov anton-trunov self-assigned this Jun 3, 2024
byakuren-hijiri
byakuren-hijiri previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor
@byakuren-hijiri byakuren-hijiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I'm happy that the names of AST assignments are finally fixed.

novusnota
novusnota previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member
@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@anton-trunov anton-trunov dismissed stale reviews from novusnota and byakuren-hijiri via 4986320 June 3, 2024 15:38
@novusnota
Copy link
Member

Timeout of math-related tests on Win 8000 dows :/

@anton-trunov anton-trunov merged commit 3db4409 into main Jun 3, 2024
3 checks passed
@anton-trunov anton-trunov deleted the fix-typos branch June 3, 2024 16:17
@anton-trunov
Copy link
Member Author

yeah, had to re-run that

Gusarich
Gusarich reviewed Jun 3, 2024
View reviewed changes
This was referenced Jun 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gusarich Gusarich Gusarich left review comments

@novusnota novusnota novusnota left review comments

@byakuren-hijiri byakuren-hijiri byakuren-hijiri left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Fix typos in comments and identifiers across codebase
4 participants
@anton-trunov @novusnota @Gusarich @byakuren-hijiri
0