feat: add sharded jetton #154
Conversation
There was a problem hiding this comment.
Huge work done here, I've added some comments but also two main one.
If we want to then copy that into stdlib we should refactor a lot of magic nubers here, they are literally in each function in shard-utils.tact.
And also I think we need to be consistent about new message/send/deploy style. Using two styles in the same time looks bad IMHO.
| @@ -25,3 +25,4 @@ tonweb | |||
| utime | |||
| workchain | |||
| yada | |||
| Toncoins | |||
| ? BasechainAddress { hash: changeAddressHashShard(getJettonWalletInit(msg.ownerAddress).hash(), ownerShard) } | ||
| : emptyBasechainAddress(); | ||
|
|
||
| message(MessageParameters { |
There was a problem hiding this comment.
Let's change this to MessageParameters.send() to be consistent
| self.totalSupply -= msg.amount; | ||
|
|
||
| if (msg.responseDestination != null) { | ||
| message(MessageParameters { |
| nativeReserve(minTonsForStorage, ReserveExact | ReserveBounceIfActionFail); | ||
|
|
||
| // we allow bounce here and don't handle it, if claim fails we just accept the TONs back | ||
| message(MessageParameters { |
| return beginCell().storeUint(sl.loadUint(11), 11).storeUint(changeAddressHashShard(sl.loadUint(256), shard), 256).asSlice().loadAddress(); | ||
| } | ||
|
|
||
| inline fun getShardFromAddress(addr: Slice): Int { |
There was a problem hiding this comment.
Maybe it's better to accept Address as a parameter and transform it into a Slice internally
| } | ||
|
|
||
| inline fun getShardFromAddress(addr: Slice): Int { | 8000||
| addr.skipBits(11); |
There was a problem hiding this comment.
please add a comment here, why it is 11
| inline extends fun hasSameBasechainAddressShard(self: StateInit, sender: Address): Bool { | ||
| let senderAddress = parseStdAddress(sender.asSlice()).address; | ||
| let baseAddress = contractBasechainAddressShard(self); | ||
| return (baseAddress.hash!! & ((1 << (256 - prefixLength)) - 1)) == (senderAddress & ((1 << (256 - prefixLength)) - 1)); |
There was a problem hiding this comment.
Did you check LSHIFT group of instructions? Maybe some of them allows logical overflow
| return addr.loadUint(prefixLength); | ||
| } | ||
|
|
||
| extends inline fun toShardCell(self: StateInit): Cell { |
There was a problem hiding this comment.
idk what is the prorer naming here, but toShardCell is confusing
| @@ -0,0 +1,223 @@ | |||
| import "./shard-utils"; | |||
There was a problem hiding this comment.
Let's group this to separate folder and add comments why we need it, or link the issue with tact-lang PR
| SENDRAWMSG | ||
| } | ||
|
|
||
| extends inline fun send(self: ShardDeployParameters) { |
There was a problem hiding this comment.
Definitely need comments here)
| }; | ||
| } | ||
|
|
||
| inline fun changeAddressHashShard(addr_hash: Int, shard: Int): Int { |
There was a problem hiding this comment.
| inline fun changeAddressHashShard(addr_hash: Int, shard: Int): Int { | |
| inline fun changeAddressHashShard(addrHash: Int, shard: Int): Int { |
| @@ -0,0 +1,70 @@ | |||
| const prefixLength: Int = 8; | |||
|
|
|||
| struct ShardDeployParameters { | |||
There was a problem hiding this comment.
Let's add something like getShardNumber(addr: Address): Int as uint8;
| return newStateInit; | ||
| } | ||
|
|
||
| inline fun contractBasechainAddressShard(s: StateInit): BasechainAddress { |
There was a problem hiding this comment.
I don't get what this function does from the name
|
|
||
| extends inline fun toShardCell(self: StateInit): Cell { | ||
| let newStateInit = beginCell() | ||
| .storeUint(32 + prefixLength, 6) |
| await blockchain.loadFrom(snapshot) | ||
| }) | ||
|
|
||
| it("should deploy in the same shard", async () => { |
There was a problem hiding this comment.
We need a lot more tests for this: failed deploy, different shards collision, different blockchain configs
Closes #150