8000 fix(protogen): also process specified workbooks on FirstPassModeAdvanced by Kybxd · Pull Request #236 · tableauio/tableau · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(protogen): also process specified workbooks on FirstPassModeAdvanced #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

Kybxd
Copy link
Collaborator
@Kybxd Kybxd commented Apr 30, 2025

No description provided.

Copy link
codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.94%. Comparing base (f85db1b) to head (6178223).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/protogen/protogen.go 64.28% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   70.95%   70.94%   -0.02%     
==========================================
  Files          80       80              
  Lines       10208    10214       +6     
==========================================
+ Hits         7243     7246       +3     
- Misses       2410     2412       +2     
- Partials      555      556       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wenchy wenchy marked this pull request as ready for review May 6, 2025 03:18
@wenchy wenchy changed the title fix: also process input workbooks on advanced mode fix(protogen): also process specified workbooks on FirstPassModeAdvanced May 6, 2025
@wenchy wenchy merged commit 4fd6952 into master May 6, 2025
7 of 8 checks passed
@wenchy wenchy deleted the fix/advanced-mode branch May 6, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0