Switch active and default colors of list groups #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I like it but I think you also need to switch the hover colours. This currently shows odd behaviour where hovering over active items will make their background white see the contact list for example on: https://tabler-git-switch-list-group-colors-tabler-ui.vercel.app/lists.html?theme=light |
096fd45 to
3dae9f8
Compare
|
@dheineman thx for the feedback! This should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List groups look a little of because they are by default darker than the rest of the content. This PR switches the default color with the active color.
Old:
https://preview.tabler.io/lists.html?theme=light
https://preview.tabler.io/lists.html?theme=dark
New:
https://tabler-git-switch-list-group-colors-tabler-ui.vercel.app/lists.html?theme=light
https://tabler-git-switch-list-group-colors-tabler-ui.vercel.app/lists.html?theme=dark