8000 Unify dark mode with latest Bootstrap API and improve dark mode elements by codecalm · Pull Request #1561 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unify dark mode with latest Bootstrap API and improve dark mode elements #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2023

Conversation

codecalm
Copy link
Member
@codecalm codecalm commented May 10, 2023

This PR unifies the dark mode in our project with the latest Bootstrap API and improves the design and functionality of dark mode elements. The updated dark mode provides a more consistent and polished user experience across our application.

8000
@changeset-bot
Copy link
changeset-bot bot commented May 10, 2023

🦋 Changeset detected

Latest commit: a9fb6c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tabler/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ✅ Ready (Inspect) Visit Preview May 11, 2023 0:40am

@kevinpapst
Copy link
Collaborator
kevinpapst commented May 10, 2023

At first glance: even better than before. A lot of BC breaks, but that's expected for 1.0 😁
Only thing I noticed during a couple of minutes browsing: the parent of sub-menus is not highlighted anymore, e.g "Layout" should be underlined here.

@codecalm
Copy link
Member Author

@kevinpapst good, I'm fixing it. If you have any other bugs give me know

@codecalm codecalm merged commit 75619dd into dev May 14, 2023
@codecalm codecalm deleted the dev-bootstrap-dark-mode branch May 14, 2023 13:54
@mholt
Copy link
Contributor
mholt commented May 15, 2023

I was using .theme-dark-auto -- what do you recommend as a replacement?

@codecalm codecalm restored the dev-bootstrap-dark-mode branch August 24, 2023 09:52
@xvilo
Copy link
xvilo commented Oct 25, 2023

As @mholt asked before, what is currently a replacement or alternative to the .theme-dark-auto. This has, unfortunately, been removed with this PR.

@codecalm are able to give us some guidance regarding the old class?

@codecalm codecalm deleted the dev-bootstrap-dark-mode branch September 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0