8000 Fix replacing href="#" with href="javascript:void(0)" by BG-Software-BG · Pull Request #1720 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix replacing href="#" with href="javascript:void(0)" #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

Fix replacing href="#" with href="javascript:void(0)" #1720

merged 1 commit into from
Sep 23, 2023

Conversation

BG-Software-BG
Copy link
Member

Replaces before using example variable.
Replace all hrefs, not only in tags.

Should prevent opening whole site inside iframe in examples in Documentation.

Fix replacing href="#" with href="javascript:void(0)"
a2c85e2 
Replaces before using example variable.
Replace all hrefs, not only in <a> tags.
@BG-Software-BG BG-Software-BG added the bug Something isn't working label Sep 23, 2023
@changeset-bot
Copy link
changeset-bot bot commented Sep 23, 2023

⚠️ No Changeset found

Latest commit: a2c85e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
vercel bot commented Sep 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ✅ Ready (Inspect) Visit Preview Sep 23, 2023 7:57am
tabler-site ✅ Ready (Inspect) Visit Preview Sep 23, 2023 7:57am

@rjd22 rjd22 merged commit e639a20 into site Sep 23, 2023
@rjd22 rjd22 deleted the dev-fix-buttons-with-href-in-examples branch September 23, 2023 12:02
@rjd22
Copy link
Collaborator
rjd22 commented Sep 23, 2023

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecalm codecalm Awaiting requested review from codecalm

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BG-Software-BG @rjd22
0