8000 Change h1 to div in navbar-logo by BG-Software-BG · Pull Request #1733 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change h1 to div in navbar-logo #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

Change h1 to div in navbar-logo #1733

merged 1 commit into from
Oct 4, 2023

Conversation

BG-Software-BG
Copy link
Member

No description provided.

@BG-Software-BG BG-Software-BG linked an issue Oct 1, 2023 that may be closed by this pull request
[BUG] Navbar uses invalid HTML element h1 #1732
Closed
@changeset-bot
Copy link
changeset-bot bot commented Oct 1, 2023

⚠️ No Changeset found

Latest commit: 119a559

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
vercel bot commented Oct 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ✅ Ready (Inspect) Visit Preview Oct 1, 2023 1:34pm
tabler-site ✅ Ready (Inspect) Visit Preview Oct 1, 2023 1:34pm

kevinpapst
kevinpapst approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator
@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@rjd22
Copy link
Collaborator
rjd22 commented Oct 4, 2023

Looks to to me! I would suggest to also move the page titles to h2 then but we can do this in a separate PR.

@rjd22 rjd22 merged commit 80f5732 into dev Oct 4, 2023
@rjd22 rjd22 deleted the dev-navbar-uses-invalid-html-element-h1 branch October 4, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpapst kevinpapst kevinpapst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Navbar uses invalid HTML element h1
3 participants
@BG-Software-BG @rjd22 @kevinpapst
0