Update _navbar.scss with disabled dropdown menu items colour #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f67b26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@codecalm - Please review the proposed changes when possible, and let me know if there are any updates/changes to be made to further resolve the issue! As a first-time open source contributor, I look forward to hearing your input. |
drew7721
reviewed
Dec 15, 2023
src/scss/layout/_navbar.scss
Outdated
Comment on lines
43
to
48
| &.disabled { | ||
| color: var(--#{$prefix}gray-300); | ||
| pointer-events: none; | ||
| background-color: transparent; | ||
| } | ||
|
|
There was a problem hiding this comment.
I would suggest properly aligning these with the rest. It breaks the flow and decreases readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve the issue mentioned in #1473
Steps taken to resolve:
Identified reason for discrepancy between horizontal and verticaldrop down menu items in the navbar - issue identified to be correlated to lack of distinction of colours for disabled items in vertical dropdown menu.
Manually recreated issue by disabling all level 2 dropdown menu items in /src/…/navbar-menu.html (i.e. all components under Interface, Extra, Layout and Help are disabled).
NOTE: Issue (mentioned in #1473) persists as there is no clear visual distinction between disabled and enabled dropdown menu items; all are displayed in the same colour, even though the Layout’s dropdown items are disabled.
Identified the .scss file corresponding to navbar-menu.html in /src/…/_navbar.scss and incorporated a separate .disabled class to address dropdown menu items that are disabled.
Set disabled dropdown menu items to color gray-300 to match with horizontal dropdown menu disabled items, as opposed to ‘inherit’ which 8000 results in it being the same colour as the element’s parent.
NOTE: As can be seen in the screenshot above, the disabled dropdown menu items in the vertical layout are now rendered in the color gray-300 (as in the horizontal layout) so disabled and enabled menu items are now clearly distinguishable.
This change was tested on an OSX environment using the Google Chrome browser. All variables mentioned under the /src directory are being displayed as expected.