8000 Replace .page-center with .my-auto in single page layouts by srsbiz · Pull Request #2009 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace .page-center with .my-auto in single page layouts #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

srsbiz
Copy link
Contributor
@srsbiz srsbiz commented Dec 8, 2024

Fixes #1820

Copy link
changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: 3ef65db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tabler/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ✅ Ready (Inspect) Visit Preview Dec 30, 2024 6:21pm

@codecalm
Copy link
Member
codecalm commented Dec 9, 2024

can you replace also in _layouts/error.html?

@codecalm codecalm merged commit f6e885b into tabler:dev Dec 30, 2024
1 check passed
@wtsvishal
Copy link

my-auto is not working but page-center is still working. so please check once.

@srsbiz
Copy link
Contributor Author
srsbiz commented Jan 3, 2025

my-auto is not working but page-center is still working. so please check once.

What exactly is not working? Please provide more details, like URL to broken page in preview.tabler.io, screen with marked area that is wrong, your browser and screen resolution.

@wtsvishal
Copy link

let's say we have open login page which should display as center of the page but due to add my-auto is used so my-auto does not work somehow but page-center instead of my-auto is working. same this happen in page-loader too.

@srsbiz
Copy link
Contributor Author
srsbiz commented Jan 13, 2025

It is centered on all major browsers - Chrome, MS Edge, Opera, FireFox

image

Unless you provide more info about your enviroment it's hard to find any solution

@wtsvishal
Copy link
wtsvishal commented Jan 17, 2025 via email

@srsbiz
Copy link
Contributor Author
srsbiz commented Jan 17, 2025

Well, the whole purpose of this change is to sacrifice vertical alignment since it does not work well with larger content.

.page-center class is stil available for use, but keep in mind that should be used only for very small content

@wtsvishal
Copy link
wtsvishal commented Jan 23, 2025 via email

@carlosmintfan
Copy link
Contributor

@wtsvishal #2114 fixes this.

@wtsvishal
Copy link
wtsvishal commented Feb 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Terms of Service demo page is cut off
4 participants
0