8000
feat: improve vertical sidebar with minification, theme mode and user menu when header is disabled by bastienrossi · Pull Request #2043 · tabler/tabler · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw that an issue has been open for some time #1803 concerning the improvement of the sidebar in vertical mode.
I've made some modifications for my needs, so I'm proposing a PR with the code.
I've tried to use as little javascript as possible with the bootstrap collapse system, but I'd like your opinion on whether you think this is a good idea or whether it's preferable to use dedicated management.
I've added a sidebar.js script to manage tooltips when the sidebar is minimized.
I've also added a button to switch from dark to light mode and a user menu that opens over the sidebar to avoid conflicts.
I added these two elements because when the header is not in use, access to the user menu and dark mode is not possible.
Don't hesitate to give me feedback on what's wrong so that I can propose an improvement.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I saw that an issue has been open for some time #1803 concerning the improvement of the sidebar in vertical mode.
I've made some modifications for my needs, so I'm proposing a PR with the code.
I've tried to use as little javascript as possible with the bootstrap collapse system, but I'd like your opinion on whether you think this is a good idea or whether it's preferable to use dedicated management.
I've added a sidebar.js script to manage tooltips when the sidebar is minimized.
I've also added a button to switch from dark to light mode and a user menu that opens over the sidebar to avoid conflicts.
I added these two elements because when the header is not in use, access to the user menu and dark mode is not possible.
Don't hesitate to give me feedback on what's wrong so that I can propose an improvement.
Here's how it looks:
Thanks