Update _nav.scss #2133
Merged
Update _nav.scss #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issue: Dash (`-`) causing W3C validator error and CSS issues
**Problem**:
The use of a dash (`-`) in certain areas is triggering errors in the W3C validator and affecting the proper functioning of CSS.
1. **HTML Issue**: The dash might be incorrectly placed in attribute names or element IDs, causing validation errors.
- Example: `data-name` is fine, but ensure it's used correctly and within the valid context.
2. **CSS Issue**: If the dash is used improperly in class or ID names, it can cause selector issues in CSS.
- Example: `.my-class-name` is correct, but make sure that the class is correctly applied to the element and styled properly in CSS.
**Proposed Fix**:
- Ensure that any attribute or class names are formatted correctly. For example, `data-name` is valid, but check for any spelling mistakes or misplaced dashes.
- In CSS, ensure proper selector syntax like:
```css
.my-class-name {
/* Styles here */
}
🦋 Changeset detectedLatest commit: 0de9bbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@FahadAlsulaiman is attempting to deploy a commit to the Tabler Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I've updated code with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Dash (
-) causing W3C validator error and CSS issuesProblem:
The use of a dash (
-) in certain areas is triggering errors in the W3C validator and affecting the proper functioning of CSS.HTML Issue: The dash might be incorrectly placed in attribute names or element IDs, causing validation errors.
data-nameis fine, but ensure it's used correctly and within the valid context.CSS Issue: If the dash is used improperly in class or ID names, it can cause selector issues in CSS.
.my-class-nameis correct, but make sure that the class is correctly applied to the element and styled properly in CSS.