8000 [WIP] - Flat Layout & Request Guidance on File Organization by Nejcc · Pull Request #2168 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WIP] - Flat Layout & Request Guidance on File Organization #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

[WIP] - Flat Layout & Request Guidance on File Organization #2168

wants to merge 6 commits into from

Conversation

Nejcc
Copy link
Contributor
@Nejcc Nejcc commented Feb 18, 2025

This is WIP PR on new Tabler flat layout

Layout Overview

Overview

This PR introduces a new layout implementation (currently at preview/pages/_layouts/flat.html). Since the Tabler core structure has undergone significant changes since my last contribution, I’m seeking guidance on properly organizing the layout files, assets (CSS/SCSS, JS), and partials.

What's Changed

  • Layout File: Introduced flat.html in preview/pages/_layouts/ as a new layout.
  • Entry Point: Noticed that base.html now serves as the main entry point using a yield content mechanism.

Questions & Guidance Needed

  1. File Organization:
    • How should the new layout be split into proper files (CSS/SCSS, JS, partials)?
    • Are there recommended directories or naming conventions for these assets in the current structure?
  2. Documentation:
    • If I’m missing documentation on these changes, could someone point me to the appropriate guide or resources?
  3. Integration:
    • Is there a preferred workflow or best practice for integrating new layouts with the core structure?

Status

  • Work in Progress (WIP): This PR is not ready for merge until I receive further guidance and adjust the file organization accordingly.

Any suggestions or pointers to the relevant documentation would be greatly appreciated. Thanks for the support and feedback!

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9b7fa21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link
vercel bot commented Feb 18, 2025

Someone is attempting to deploy a commit to the Tabler Team on Vercel.

A member of the Team first needs to authorize it.

@Nejcc Nejcc marked this pull request as draft February 18, 2025 12:45
@its-miroor

This comment was marked as off-topic.

Sign in to view
@argos-ci Argos CI
Copy link
argos-ci bot commented Feb 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ Auto-approved build (Review) 79 changed, 1 added Feb 20, 2025, 6:16 AM

@Nejcc
Copy link
Contributor Author
Nejcc commented Feb 20, 2025

@codecalm

  1. File Organization:
    • How should the new layout be split into proper files (CSS/SCSS, JS, partials)?
    • Are there recommended directories or naming conventions for these assets in the current structure?
  2. Documentation:
    • If I’m missing documentation on these changes, could someone point me to the appropriate guide or resources?
  3. Integration:
    • Is there a preferred workflow or best practice for integrating new layouts with the core structure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nejcc @its-miroor
0