8000 Fix incorrect label text on form elements docs page by ethancrawford · Pull Request #2334 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix incorrect label text on form elements docs page #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

ethancrawford
Copy link
Collaborator

The example of an input with an appended <kbd> previously had a change introduced in #1492 to its label that was incorrect.

This commit brings it back to what it was originally, as first written in #1391.

Before this change:
image

After this change:
image

The example of an input with an appended <kbd> previously had a change to its
label that was incorrect. This commit brings it back to what it was originally.
Copy link
changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: 4f5b87f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tabler/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
vercel bot commented May 5, 2025

@ethancrawford is attempting to deploy a commit to the Tabler Team on Vercel.

A member of the Team first needs to authorize it.

@kevinpapst
Copy link
Collaborator
kevinpapst commented May 5, 2025

@ethancrawford
Copy link
Collaborator Author

There is a corresponding example on the preview site at https://preview.tabler.io/form-elements.html:
image

@ethancrawford ethancrawford changed the title Fix incorrect label text on form elements page Fix incorrect label text on form elements docs page May 5, 2025
@kevinpapst
Copy link
Collaborator
kevinpapst commented May 5, 2025

Sorry, what I actually meant: could you update the other doc as well, because it also looks wrong

@ethancrawford
Copy link
Collaborator Author

@kevinpapst - not sure which other doc you are referring to, apologies 😅

@kevinpapst
Copy link
Collaborator

Excuse me, I got confused between several branches. Ignore my question!

@codecalm codecalm merged commit c42b104 into tabler:dev May 5, 2025
2 of 4 checks passed
@ethancrawford ethancrawford deleted the fix-appended-kbd-label branch May 7, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0