8000 Move additional libraries to Tabler core by codecalm · Pull Request #2385 · tabler/tabler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move additional libraries to Tabler core #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Move additional libraries to Tabler core #2385

merged 1 commit into from
May 19, 2025

Conversation

codecalm
Copy link
Member

No description provided.

@vercel Vercel
Copy link
vercel bot commented May 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ✅ Ready (Inspect) Visit Preview May 17, 2025 9:10pm
tabler-docs ✅ Ready (Inspect) Visit Preview May 17, 2025 9:10pm

@kevinpapst
Copy link
Collaborator

What are the consequences of that change?
I don't understand all the internal build files: does that change the released file structure?

@codecalm
Copy link
Member Author

yes, from now all librares will be served from @tabler/core instead of outside libraries.

@kevinpapst
Copy link
Collaborator

Let me rephrase the question: will there still be vendor files in the Tabler npm package?
I am just wondering about BC breaks that should be documented

@codecalm
Copy link
Member Author

yes, I don't know is is a breaking change, because old links will be works still. This is mainly for the comfort of the users, so that they could be sure always that the vendor lib version was definitely compatible with Tabler

@kevinpapst
Copy link
Collaborator

Aha, so you are inlining the vendor files?
But there will still be vendors.css / js file?

@codecalm
Copy link
Member Author
codecalm commented May 18, 2025 •
edited
Loading

yes, yes

from now you can include library from eg. @tabler/core/dist/libs/apexcharts/apxcharts.min.js instead of install new dependency and include apexcharts/apxcharts.min.js

If you upgrade Tabler all vendor libraries will update automatically

@kevinpapst
Copy link
Collaborator

Thanks for the explanation 👍
I am maintaining the Symfony bundle for Tabler and was curious if I need to update it.
Sounds like a good idea, so I am always using the correct vendor version.

@codecalm codecalm merged commit ad54f61 into dev May 19, 2025
6 checks passed
@codecalm codecalm deleted the dev-move-libs-to-core branch May 19, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecalm @kevinpapst
0