Fix wchar_t in C bindings, add MinGW to CI to reproduce issue (#1273) #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fail on MinGW because its gcc does not have wchar_t without including wchar.h. With g++ as used with test_tag_c.cpp, the problem is undetected because g++ supports wchar_t without including wchar.h.
In C++, wchar_t is a built-in fundamental type, but in C, it is not. Compilation with MinGW will fail without a header included which defines wchar_t (wchar.h or stddef.h). The other compilers used in our CI (gcc on Ubuntu, clang on macOS and MSVC on Windows) seem to know wchar_t without an include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.