cmd: upgrade to ffcli v3 #2688
Merged
cmd: upgrade to ffcli v3 #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No benefit to us (thus only risk), so wait until 1.14 is branched. |
|
Depaware sad, otherwise LGTM once 1.14 is branched |
None of the breaking changes from v2 to v3 are relevant to us. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
42359b0 to
ff451ba
Compare
|
Any end-user visible changes? |
|
Minor:
(see peterbourgon/ff#58) And a usage message fix: peterbourgon/ff@556df77#diff-3545777a4b0e13027c3af0e07e7edece2861f0adc7afe2b26fbff4db0baa35f9 |
|
We override that flag printing code anyway, so that last linked change shouldn't affect us. |
|
OK, I'm going to pull the trigger on this, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the breaking changes from v2 to v3 are relevant to us.
Signed-off-by: Josh Bleecher Snyder josh@tailscale.com