README.md: update required scopes for oauth clients #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the `all:read` and `devices:core` required scopes discussed in tailscale#100 Signed-off-by: Seb Pretzer <24555985+sebpretzer@users.noreply.github.com>
|
Hey @sebpretzer ! Were you seeing errors or failures when using the action without I've put up #183 which added a second OAuth client to our test suite with just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guidance provided for the proper scopes for oauth clients is incomplete. It only includes the
auth_keysscope, but any oauth client using this github action should also includeall:readanddevices:core. This follows the suggestion provided in #100 (comment).I have attempted to follow the contributing guidelines found in commit-messages.md.
Note: The documentation on tailscale's website will need to be updated as well.