Allow tracking on Instances (by not assigning a tracking_score)
#1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InstancesInstances (by not assigning a tracking_score)
Codecov Report
@@ Coverage Diff @@
## develop #1301 +/- ##
===========================================
- Coverage 72.36% 72.34% -0.02%
===========================================
Files 133 133
Lines 23662 23666 +4
===========================================
- Hits 17123 17122 -1
- Misses 6539 6544 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Instances (by not assigning a tracking_score)Instances (by not assigning a tracking_score)
11 tasks
|
If user instances are being tracked, then they should have a tracking score (see #1302). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to Allow Retracking, we did not allow any tracking on user instances. Since re-tracking enables users to run tracking on user instances, we now need to either add a
tracking_scoreattribute to user-instances, or refrain from assigning the tracking score if the matched instance is a user instance. I am in favor of adding the tracking score to user instances (see #1302), but this PR just refrains from assigning.Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️