8000 Remove `VisualPredictor` class by roomrys · Pull Request #2167 · talmolab/sleap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove VisualPredictor class #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

Remove VisualPredictor class #2167

merged 4 commits into from
Apr 15, 2025

Conversation

roomrys
Copy link
Collaborator
@roomrys roomrys commented Apr 10, 2025 •
edited
Loading

Description

This PR removes the broken-for-years VisualPredictor class.

Why?

  • it has been broken for years
  • self containing sleap.nn is a higher priority

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (removal)

Does this address any currently open issues?

Older

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that y 8000 our feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@roomrys roomrys mentioned this pull request Apr 10, 2025
Open
@codecov Codecov
Copy link
codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (7991f14) to head (c42a089).
Report is 107 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2167      +/-   ##
===========================================
+ Coverage    75.43%   76.35%   +0.91%     
===========================================
  Files          134      133       -1     
  Lines        24749    24909     +160     
===========================================
+ Hits         18670    19019     +349     
+ Misses        6079     5890     -189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roomrys roomrys marked this pull request as ready for review April 11, 2025 01:14
roomrys
roomrys commented Apr 15, 2025
View reviewed changes
Copy link
Collaborator Author
@roomrys roomrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 in subgroup

@roomrys roomrys merged commit a105164 into develop Apr 15, 2025
4 checks passed
@roomrys roomrys deleted the liezl/remove-visual-predictor branch April 15, 2025 22:35
This was referenced Apr 15, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roomrys
0