8000 Revert "Pulling finished work from #484 into a separate PR" by arie-matsliah · Pull Request #504 · talmolab/sleap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Pulling finished work from #484 into a separate PR" #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2021
Merged

Revert "Pulling finished work from #484 into a separate PR" #504

merged 7 commits into from
Mar 6, 2021

Conversation

arie-matsliah
Copy link
Contributor

Reverts #493

@arie-matsliah arie-matsliah requested a review from talmo March 5, 2021 20:50
@codecov-io
Copy link

Codecov Report

Merging #504 (39423b3) into develop (0cafa91) will increase coverage by 0.01%.
The diff coverage is 37.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    64.96%   64.98%   +0.01%     
===========================================
  Files          124      124              
  Lines        19699    19638      -61     
===========================================
- Hits         12798    12761      -37     
+ Misses        6901     6877      -24
Impacted Files Coverage Δ
sleap/gui/dialogs/importvideos.py 86.32% <ø> (+0.28%) ⬆️
sleap/gui/dialogs/metrics.py 18.75% <0.00%> (ø)
sleap/gui/learning/configs.py 46.19% <0.00%> (-0.90%) ⬇️
sleap/gui/learning/dialog.py 14.56% <0.00%> (ø)
sleap/gui/learning/runners.py 31.03% <0.00%> (+0.19%) ⬆️
sleap/io/dataset.py 77.48% <ø> (+0.62%) ⬆️
sleap/gui/commands.py 59.40% <50.00%> (-0.14%) ⬇️
sleap/gui/suggestions.py 51.96% <66.66%> (-2.41%) ⬇️
sleap/gui/app.py 76.82% <83.33%> (+0.11%) ⬆️
sleap/gui/overlays/tracks.py 65.81% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cafa91...39423b3. Read the comment docs.

@talmo
Copy link
Collaborator
talmo commented Mar 5, 2021

For future reference:

I kept lots of the changes in, but reverted:

  • Suggestion generation text (too bulky in the old panels-based layout)
  • Suggestions UI elements
  • All the sleap.learning.configs changes since it was failing to detect some of the default training profiles

@talmo talmo merged commit 819387d into develop Mar 6, 2021
@talmo talmo deleted the revert-493-arie/ux branch March 6, 2021 03:11
arie-matsliah added a commit that referenced this pull request Mar 8, 2021
@arie-matsliah @talmo
Merge develop to master (#507)
d9c7fee 
* Merge main back into develop (#491)

* Prep for master->main (#475)

Co-authored-by: Arie Matsliah <arie.matsliah@gmail.com>

* Release version 1.1.0

* Remove appveyor

Co-authored-by: Talmo Pereira <talmo@princeton.edu>
Co-authored-by: Arie Matsliah <arie.matsliah@gmail.com>

* Merge main to develop post release (#492)

* Prep for master->main (#475)

Co-authored-by: Arie Matsliah <arie.matsliah@gmail.com>

* Release version 1.1.0

* Remove appveyor

* Test docs subfolders

* Test keep_files

Co-authored-by: Talmo Pereira <talmo@princeton.edu>
Co-authored-by: Arie Matsliah <arie.matsliah@gmail.com>

* Pulling finished work from #484 into a separate PR (#493)

* Pulling finished work into a separate PR

* fix test

* fix

* Simplify + tweak background

* Update docs (#495)

* Isolated fix for issue #480 (#498)

* Add support for specifying the minimum score in PAF matching (#502)

Effective at filtering out explicitly spurious matches when no better match is available

* Fix post-training errors (#503)

- Catch filesystem busy error when deleting viz dir
- Don't throw an error after training with no inference target

* Revert "Pulling finished work from #484 into a separate PR" (#504)

* Minor fixes and enhacements (#505)

- Add skeleton.find_neighbors convenience graph op
- Add Instance.fill_missing to initialize new nodes in the skeleton
- Also add numpy() and from_pointsarray() aliases to PredictedInstance
  to prevent crashes from using the inherited versions
- Initialize missing instance nodes when plotting user instances
- Fix serialization after loading MediaVideo from high level API
- Fix single instance visualization during training
- Add --open-in-gui CLI option to sleap-track
- Clearer error message when running sleap-track without args

* [WIP] Fix multi size video support (#501)

* wip

* cleanup

* Add `max_height_and_width` property to `VideoReader`

* Fix SizeMatcher instantiation without specified targets
- Lint/line length

* Provider now recreates the data pipeline with new providers

* Vectorize padding test for SizeMatcher

* Do not require instances key if not available from provider

* Size matching

* Size matching fix

* Fix shapes in output dataset

* lint

Co-authored-by: Talmo Pereira <talmo@princeton.edu>

* Bump version for release (#506)

Co-authored-by: Talmo Pereira <talmo@princeton.edu>
Co-authored-by: Arie Matsliah <arie.matsliah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talmo talmo Awaiting requested review from talmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arie-matsliah @codecov-io @talmo
0