8000 Fix failing grayscale conversion at inference time on GPU by talmo · Pull Request #639 · talmolab/sleap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix failing grayscale conversion at inference time on GPU #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

Fix failing grayscale conversion at inference time on GPU #639

merged 1 commit into from
Feb 3, 2022

Conversation

talmo
Copy link
Collaborator
@talmo talmo commented Feb 3, 2022

Description

Fix grayscale conversion at inference time when video is not automatically detected as grayscale at load time.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

#638

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov-commenter
Copy link

Codecov Report

Merging #639 (8880eea) into develop (5f9fa86) will increase coverage by 0.02%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
+ Coverage    64.90%   64.93%   +0.02%     
===========================================
  Files          124      124              
  Lines        20138    20157      +19     
===========================================
+ Hits         13071    13089      +18     
- Misses        7067     7068       +1
Impacted Files Coverage Δ
sleap/nn/inference.py 63.80% <95.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9fa86...8880eea. Read the comment docs.

@talmo talmo merged commit 995808a into develop Feb 3, 2022
@talmo talmo deleted the talmo/fix-rgb2gray branch February 3, 2022 16:20
talmo added a commit that referenced this pull request Feb 9, 2022
@talmo
Fix regression in #639 breaking multi-size inference
b816cf6
@talmo talmo mentioned this pull request Feb 9, 2022
Merged
11 tasks
talmo added a commit that referenced this pull request Feb 9, 2022
@talmo
Fix regression in #639 breaking multi-size inference (#645)
a224869 
Apply SizeMatcher before Normalizer in inference pipelines
@talmo talmo mentioned this pull request Jun 7, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talmo @codecov-commenter
0