Add test and fix for GPU memory query #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
- Coverage 67.58% 67.57% -0.02%
===========================================
Files 130 130
Lines 22227 22240 +13
===========================================
+ Hits 15023 15028 +5
- Misses 7204 7212 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roomrys
reviewed
Sep 13, 2022
Comment on lines
+205
to
+208
| try: | ||
| memory_poll = subprocess.run(command, capture_output=True) | ||
| except (subprocess.SubprocessError, FileNotFoundError): | ||
| return [] |
There was a problem hiding this comment.
It would be nice to have a logger print something here for when we actually find a good GPU to use or just default to 0.
sleap/nn/training.py
Outdated
Comment on lines
1946
to
1951
| if args.gpu == "auto": | ||
| gpu_ind = np.argmax(sleap.nn.system.get_gpu_memory()) | ||
| gpu_memory = sleap.nn.system.get_gpu_memory() | ||
| gpu_ind = np.argmax(gpu_memory) if len(gpu_memory) > 0 else 0 | ||
| else: | ||
| gpu_ind = int(args.gpu) | ||
| sleap.nn.system.use_gpu(gpu_ind) |
There was a problem hiding this comment.
We can also add a logging statement here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that #911 introduces an error on some systems that can't query
nvidia-smi.This PR catches that.
Types of changes
Does this address any currently open issues?
#949
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️