Fix test_series.py error in get_frame rice tests
#96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 77.44% 77.44%
=======================================
Files 13 13
Lines 1419 1419
=======================================
Hits 1099 1099
Misses 320 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eberrigan
requested changes
Mar 18, 2025
| @@ -270,6 +270,7 @@ def test_get_frame_rice_10do( | |||
| expected_labels = sio.load_slp(rice_main_10do_slp) | |||
| # Get the first labeled frame | |||
| expected_labeled_frame = expected_labels[0] | |||
| expected_labeled_frame_pts = expected_labeled_frame.instances[0] | |||
There was a problem hiding this comment.
so this one only had one instance, or are the instances of shape (1, instances, nodes, 2)?
| @@ -280,9 +281,39 @@ def test_get_frame_rice_10do( | |||
| # Get the crown labeled frame | |||
| crown_lf = frames.get("crown") | |||
|
|
|||
| # Compare instances | |||
| get_ellipse_ratio, | ||
| ) | ||
|
|
||
| from sleap_roots.summary import get_summary | ||
|
|
||
|
|
||
| def test_numpy_array_serialization(): |
There was a problem hiding this comment.
this is a strange name for the test. where id that come from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_series.pyfrom teststest_get_frame_rice_10doandtest_get_frame_rice_10do_np_videothat raised error due to incorrect comparison of objects