8000 Add enum for properties by tamdaz · Pull Request #5 · tamdaz/crygen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add enum for properties #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom< 8000 /a>
Merged
merged 6 commits into from
Feb 3, 2025
Merged

Add enum for properties #5

merged 6 commits into from
Feb 3, 2025

Conversation

tamdaz
Copy link
Owner
@tamdaz tamdaz commented Feb 1, 2025 •
edited
Loading

Description

Overloaded add_property methods have a visibility argument of type Symbol. However, this argument can add any name in addition to the getter, property and setter values.
To solve this problem, an enum Crygen::Enums::PropVisibility is added to limit the number of names to the 3 mentioned above.

Changelog

  • visibility arg type has changed into Crygen::Enums::PropVisibility enum.

Issue reference

Visibility name of the property can be anything : #4

@tamdaz tamdaz added bug Something isn't working improvement Refactor or optimize the code labels Feb 1, 2025
@tamdaz tamdaz self-assigned this Feb 1, 2025
@tamdaz tamdaz added invalid This doesn't seem right and removed bug Something isn't working labels Feb 1, 2025
@tamdaz tamdaz merged commit fd7d7c7 into main Feb 3, 2025
2 checks passed
@tamdaz tamdaz deleted the fix/prop-visibility branch February 3, 2025 19:53
@tamdaz tamdaz added this to the v0.2.0 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tamdaz tamdaz

Labels
improvement Refactor or optimize the code invalid This doesn't seem right
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@tamdaz
0