-
Notifications
You must be signed in to change notification settings - Fork 20
feat(tangle-cloud): List operators in the Operators page #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tangle-leaderboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Update on this PR:
CleanShot.2025-04-30.at.03.24.55.mp4WIP 🚧 I am moving a lot of code to Note ❗ Cannot register for a blueprint due to changes in the runtime and we need to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the blueprint pricing functionality by renaming and repurposing it to configure the RPC URL for blueprints while also adding a new Operators page with its associated layout. Key changes include:
- Replacing ConfigurePricingModal with ConfigureBlueprintModal in blueprint-related pages.
- Removing pricing-related components, types, and inputs across several files.
- Updating constants, routing, and layout components for the new Operators page.
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
apps/tangle-cloud/src/pages/operators/layout.tsx | Added a simple layout component for the Operators page. |
apps/tangle-cloud/src/pages/blueprints/page.tsx | Renamed modal state and submission callbacks to use blueprint terminology. |
apps/tangle-cloud/src/pages/blueprints/[id]/page.tsx | Updated blueprint modal handling, aligning modal state and form submission with new naming. |
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/type.ts | Removed obsolete pricing field from the operator selection table type. |
apps/tangle-cloud/src/pages/blueprints/ConfigurePricingModal/* | Removed pricing modal components and associated types. |
apps/tangle-cloud/src/pages/blueprints/ConfigureBlueprintModal/* | Introduced new modal and types for configuring the RPC URL for blueprints. |
apps/tangle-cloud/src/constants/links.ts | Updated the link constant from operator pricing to the operator RPC URL. |
apps/tangle-cloud/src/app/app.tsx | Added routing for the newly created Operators page. |
.vscode/settings.json | Updated VSCode settings to include a new nxConsole rule. |
sessionStorage.setItem( | ||
SessionStorageKey.BLUEPRINT_REGISTRATION_PARAMS, | ||
JSON.stringify({ | ||
pricingSettings: result, | ||
rpcUrl: result, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistency in how the RPC URL value is set: here it is directly assigned from 'result', while in the [id] page it is accessed as 'result.values.rpcUrl'. Please verify and update the submission callback to consistently extract the RPC URL.
rpcUrl: result, | |
rpcUrl: result.values.rpcUrl, |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I had deleted this file
Summary of changes
Summary of Changes
Proposed area of change
apps/tangle-dapp
apps/tangle-cloud
apps/leaderboard
libs/tangle-shared-ui
libs/ui-components
Associated issue(s)
Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.