8000 feat(tangle-cloud): List operators in the Operators page by devpavan04 · Pull Request #3005 · tangle-network/dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(tangle-cloud): List operators in the Operators page #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2025

Conversation

devpavan04
Copy link
Member
@devpavan04 devpavan04 commented Apr 28, 2025

Summary of changes

Summary of Changes

Proposed area of change

  • apps/tangle-dapp
  • apps/tangle-cloud
  • apps/leaderboard
  • libs/tangle-shared-ui
  • libs/ui-components

Associated issue(s)

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

Copy link
netlify bot commented Apr 28, 2025

Deploy Preview for tangle-leaderboard ready!

Name Link
🔨 Latest commit 82fe511
🔍 Latest deploy log https://app.netlify.com/projects/tangle-leaderboard/deploys/6827e6c701d4a400087ef349
😎 Deploy Preview https://deploy-preview-3005--tangle-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Apr 28, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 82fe511
🔍 Latest deploy log https://app.netlify.com/projects/tangle-cloud/deploys/6827e6c7a06fa40008e702a9
😎 Deploy Preview https://deploy-preview-3005--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Apr 28, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 82fe511
🔍 Latest deploy log https://app.netlify.com/projects/tangle-dapp/deploys/6827e6c775e557000876ddd4
😎 Deploy Preview https://deploy-preview-3005--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@devpavan04 devpavan04 marked this pull request as draft April 28, 2025 15:54
@devpavan04
Copy link
Member Author

@yuri-xyz @drewstone

Update on this PR:

  • Operators Table view in tangle-cloud
  • User can register as an operator in tangle-cloud
CleanShot.2025-04-30.at.03.24.55.mp4

WIP 🚧

I am moving a lot of code to tangle-shared-ui and removing items from tangle-dapp

Note ❗

Cannot register for a blueprint due to changes in the runtime and we need to update the @tangle-network/tangle-substrate-types package to make it work. It will be handled in the next PR once v1.3.3 : update types/jobs #993 is merged and published

@devpavan04 devpavan04 marked this pull request as ready for review May 17, 2025 01:17
@yuri-xyz yuri-xyz requested review from Copilot and removed request for danielbui12 May 17, 2025 11:19
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the blueprint pricing functionality by renaming and repurposing it to configure the RPC URL for blueprints while also adding a new Operators page with its associated layout. Key changes include:

  • Replacing ConfigurePricingModal with ConfigureBlueprintModal in blueprint-related pages.
  • Removing pricing-related components, types, and inputs across several files.
  • Updating constants, routing, and layout components for the new Operators page.

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/tangle-cloud/src/pages/operators/layout.tsx Added a simple layout component for the Operators page.
apps/tangle-cloud/src/pages/blueprints/page.tsx Renamed modal state and submission callbacks to use blueprint terminology.
apps/tangle-cloud/src/pages/blueprints/[id]/page.tsx Updated blueprint modal handling, aligning modal state and form submission with new naming.
apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/type.ts Removed obsolete pricing field from the operator selection table type.
apps/tangle-cloud/src/pages/blueprints/ConfigurePricingModal/* Removed pricing modal components and associated types.
apps/tangle-cloud/src/pages/blueprints/ConfigureBlueprintModal/* Introduced new modal and types for configuring the RPC URL for blueprints.
apps/tangle-cloud/src/constants/links.ts Updated the link constant from operator pricing to the operator RPC URL.
apps/tangle-cloud/src/app/app.tsx Added routing for the newly created Operators page.
.vscode/settings.json Updated VSCode settings to include a new nxConsole rule.

sessionStorage.setItem(
SessionStorageKey.BLUEPRINT_REGISTRATION_PARAMS,
JSON.stringify({
pricingSettings: result,
rpcUrl: result,
Copy link
Preview
Copilot AI May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency in how the RPC URL value is set: here it is directly assigned from 'result', while in the [id] page it is accessed as 'result.values.rpcUrl'. Please verify and update the submission callback to consistently extract the RPC URL.

Suggested change
rpcUrl: result,
rpcUrl: result.values.rpcUrl,

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had deleted this file

@drewstone drewstone merged commit b59c148 into develop May 17, 2025
20 checks passed
@drewstone drewstone deleted the pavan/cloud-operators-page branch May 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update blueprints registration flow [FEAT] List operators in the Operators page [FEAT] Registering for blueprints/joining the operator set
3 participants
0