8000 TAP-5221:feat js support unset by weiliang110100 · Pull Request #2677 · tapdata/tapdata · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TAP-5221:feat js support unset #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

TAP-5221:feat js support unset #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../io/tapdata/flow/engine/V2/node/hazelcast/processor/HazelcastJavaScriptProcessorNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ protected void tryProcess(TapdataEvent tapdataEvent, BiConsumer<TapdataEvent, Pr
contextMap.put("info", tapEvent.getInfo());
contextMap.put("global", this.globalTaskContent);
contextMap.put("isReplace", tapEvent instanceof TapUpdateRecordEvent && Boolean.TRUE.equals(((TapUpdateRecordEvent) tapEvent).getIsReplaceEvent()));
contextMap.put("removedFields", TapEventUtil.getRemoveFields(tapEvent));
Map<String, Object> context = this.processContextThreadLocal.get();
context.putAll(contextMap);

Expand Down
14 changes: 10 additions & 4 deletions iengine/iengine-common/src/main/java/io/tapdata/flow/engine/V2/util/TapEventUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,16 @@ public static List<String> getNamespaces(TapEvent tapEvent) {
}

public static List<String> getRemoveFields(TapEvent tapEvent) {
if (tapEvent instanceof TapUpdateRecordEvent) {
return ((TapUpdateRecordEvent) tapEvent).getRemovedFields();
} else if (tapEvent instanceof TapInsertRecordEvent) {
return ((TapInsertRecordEvent) tapEvent).getRemovedFields();
if (tapEvent instanceof TapUpdateRecordEvent updateRecordEvent) {
if(null == updateRecordEvent.getRemovedFields()){
updateRecordEvent.setRemovedFields(new ArrayList<>());
}
return updateRecordEvent.getRemovedFields();
} else if (tapEvent instanceof TapInsertRecordEvent insertRecordEvent) {
if(null == insertRecordEvent.getRemovedFields()){
insertRecordEvent.setRemovedFields(new ArrayList<>());
}
return insertRecordEvent.getRemovedFields();
}
return null;
}
Expand Down
10 changes: 9 additions & 1 deletion iengine/iengine-common/src/test/java/io/tapdata/flow/engine/V2/util/TapEventUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,21 @@ void testGetRemoveFields() {
List<String> removeFields = TapEventUtil.getRemoveFields(tapUpdateRecordEvent);
assertEquals("abc", removeFields.get(0));
assertEquals("123", removeFields.get(1));
TapInsertRecordEvent tapInsertRecordEvent = new TapInsertRecordEvent();
tapInsertRecordEvent.setRemovedFields(stringList);
removeFields = TapEventUtil.getRemoveFields(tapInsertRecordEvent);
assertEquals("abc", removeFields.get(0));
assertEquals("123", removeFields.get(1));
}

@Test
void testGetNullRemoveFields() {
TapUpdateRecordEvent tapUpdateRecordEvent = new TapUpdateRecordEvent();
List<String> removeFields = TapEventUtil.getRemoveFields(tapUpdateRecordEvent);
assertNull(removeFields);
assertEquals(0,removeFields.size());
TapInsertRecordEvent tapInsertRecordEvent = new TapInsertRecordEvent();
removeFields = TapEventUtil.getRemoveFields(tapInsertRecordEvent);
assertEquals(0,removeFields.size());
}

@Test
Expand Down
0