[backport 3.3] cmake: fix LTO build on Fedora #11521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a follow-up to the commit 25af976 ("build: support cmake 4.0"). Since version 3.4, CMake doesn't add flags to export symbols from executables without the ENABLE_EXPORTS target property, see CMP0065 [1] for details. Without this property, some unit C tests produce build warnings with LTO optimization enabled (for example, on Fedora 39): NO_WRAP ``` [ 72%] Linking CXX executable luaT_tuple_new.test In function ‘rmean_collect’, inlined from ‘txn_complete_success’ at src/box/txn.c:836:2, inlined from ‘txn_limbo_complete’ at src/box/txn_limbo.c:205:3: src/lib/core/rmean.c:65:9: error: ‘__atomic_add_fetch_8’ writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] 65 | __atomic_add_fetch(&rmean->stats[name].value[0], value, __ATOMIC_RELAXED); | ^ In function ‘txn_limbo_complete’: lto1: note: destination object is likely at address zero ``` NO_WRAP The real reason should be investigated in the scope of #11517. The compilation warning may be suppressed, but it may also mask the actual problems in the future tests. The CMP0065 is removed from CMake version 4.0 [2]. Thus, this patch fixes the behaviour by setting the property `ENABLE_EXPORTS` for unit tests directly. [1]: https://cmake.org/cmake/help/latest/policy/CMP0065.html [2]: https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html#policies-introduced-by-cmake-3-4-removed-by-cmake-4-0 NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 2bde926)
ligurio
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #11509 to
release/3.3to a future3.3.3release.)This patch is a follow-up to the commit
25af976 ("build: support cmake 4.0"). Since version 3.4, CMake doesn't add flags to export symbols from executables without the ENABLE_EXPORTS target property, see CMP0065 1 for details. Without this property, some unit C tests produce build warnings with LTO optimization enabled (for example, on Fedora 39):
NO_WRAP
NO_WRAP
The CMP0065 is removed from CMake version 4.0 2. Thus, this patch fixes the behaviour by setting the property
ENABLE_EXPORTSfor unit tests directly.NO_DOC=build
NO_TEST=build
NO_CHANGELOG=build
Originally observed on 2.11, see this CI run. But may be reproduced on the master branch with the following Dockerfile:
In the Docker: clone the Tarantool repo and build with the following command: