8000 uninstall: add tt uninstall tcm command by dmyger · Pull Request #1160 · tarantool/tt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

uninstall: add tt uninstall tcm command #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Conversation

dmyger
Copy link
Collaborator
@dmyger dmyger commented May 12, 2025

Added opposite command to remove installed tcm.

The command finds the locally installed version of TCM and removes
it from the system. If no version is specified, the current version
of TCM that is in use at the moment is deleted. If the actual version
is deleted, the symbolic link tcm in the bin folder is also deleted.

Usage Example:
Remove specific TCM version:

tt uninstall tcm 1.2.3-0-geae7e7d49

Remove actual active TCM version:

tt uninstall tcm

I didn't forget about (remove if it is not applicable):

  • Well-written commit messages (see documentation how to write a commit message)
  • Don't forget about TarantoolBot in a commit message (see example)
  • Tests (see documentation for a testing package)
  • Changelog (see documentation for changelog format)
  • Documentation (see documentation for documentation style guide)

Closes #TNTP-1096

@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch from cae4a59 to 51c77de Compare May 13, 2025 09:03
@dmyger dmyger force-pushed the dmyger/tntp-1096_tcm_uninstall branch from f2e9b9f to 6444749 Compare May 13, 2025 09:15
@dmyger dmyger marked this pull request as ready for review May 13, 2025 17:12
@patapenka-alexey
Copy link
Contributor

Works as expected. Please fix Closes #tntp-1096 -> Closes #TNTP-1096 in the commit message and I will approve.

@dmyger dmyger force-pushed the dmyger/tntp-1096_tcm_uninstall branch from e7cd8d4 to bde48b9 Compare May 14, 2025 11:51
@dmyger
Copy link
Collaborator Author
dmyger commented May 14, 2025

Works as expected. Please fix Closes #tntp-1096 -> Closes #TNTP-1096 in the commit message and I will approve.

Done

@dmyger dmyger added the full-ci Enables full ci tests label May 14, 2025
@dmyger dmyger force-pushed the dmyger/tntp-1096_tcm_uninstall branch from bde48b9 to 1c0cf9c Compare May 14, 2025 12:01
@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch from 51c77de to 622b4bc Compare May 14, 2025 13:57
@dmyger dmyger force-pushed the dmyger/tntp-1096_tcm_uninstall branch from 1c0cf9c to b402558 Compare May 14, 2025 13:59
@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch from 622b4bc to 58570fb Compare May 14, 2025 14:20
@dmyger dmyger force-pushed the dmyger/tntp-1096_tcm_uninstall branch from b402558 to 27380ae Compare May 14, 2025 14:29
Base automatically changed from dmyger/tntp-1095_tcm_install to master May 15, 2025 20:37
dmyger added 2 commits May 15, 2025 23:39
This commit adds the ability to remove installed TCM package using
the `tt uninstall tcm` command. The TCM uninstallation works like to
the removing other Tarantool executables.

@TarantoolBot
Title: added `tt uninstall tcm`

The command finds the locally installed version of TCM and removes
it from the system. If no version is specified, the current version
of TCM that is in use at the moment is deleted. If the actual version
is deleted, the symbolic link `tcm` in the `bin` folder is also deleted.

**Usage Example**:
Remove specific TCM version:
```bash
tt uninstall tcm 1.2.3-0-geae7e7d49
```

Remove actual active TCM version:
```bash
tt uninstall tcm
```

Closes #TNTP-1096
@dmyger dmyger force-pushed the dmyger/tntp-1096_tcm_uninstall branch from 27380ae to 02d3397 Compare May 15, 2025 20:39
Copy link
Contributor
@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are red.

@dmyger
Copy link
Collaborator Author
dmyger commented May 16, 2025

Tests are red.

It seems as flaky cartridge tests.

@dmyger dmyger requested a review from oleg-jukovec May 16, 2025 12:29
@oleg-jukovec
Copy link
Contributor

Please, add examples of the command into the PR message.

@dmyger
Copy link
Collaborator Author
dmyger commented May 19, 2025

Please, add examples of the command into the PR message.

Done

@dmyger dmyger merged commit b369c26 into master May 19, 2025
24 checks passed
@dmyger dmyger deleted the dmyger/tntp-1096_tcm_uninstall branch May 19, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0