tarantool · dmyger · Jun 26, 2025 · Jun 16, 2025 · Jun 23, 2025 · Jun 23, 2025
diff --git a/.github/actions/static-code-check/action.yml b/.github/actions/static-code-check/action.yml
@@ -4,31 +4,38 @@ description: "Performs static code checks."
 runs:
   using: "composite"
   steps:
-      - name: Log versions
-        run: |
-          go version
-          mage --version
-          tarantool --version
-          rpm --version
-        shell: bash
+    - name: Log versions
+      run: |
+        go version
+        mage --version
+        tarantool --version
+        rpm --version
+      shell: bash
 
-      - name: Codespell checks
-        run: mage codespell
-        shell: bash
+    - name: License checker
+      run: |
+        go install github.com/uw-labs/lichen@latest
+        mage checklicenses
+      shell: bash
 
-      - name: License checker
-        run: |
-          go install github.com/uw-labs/lichen@latest
-          mage checklicenses
-        shell: bash
+    - name: Find git base branch
+      shell: bash
+      run: |
+        HASH=$(git log --format='%H^%D' | grep 'origin/' | head -n 2 | tail -n 1 | cut -f1 -d^)
+        echo "Found base branch with hash: '${HASH}'"
+        echo "BASE_BRANCH=${HASH}" >> ${GITHUB_ENV}
 
-      - name: Go Linter
-        uses: golangci/golangci-lint-action@v3
-        with:
-          version: v1.63.4
-          args: --config=golangci-lint.yml --out-${NO_FUTURE}format colored-line-number
-          skip-cache: true
+    # FIXME: Enable golangci-lint-diff after PR #1173 is merged.
+    # - name: pre-commit checks (diff)
+    #   uses: pre-commit/action@v3.0.1
+    #   env:
+    #     SKIP: golangci-lint-full
+    #   with:
+    #     extra_args: --all-files --from-ref=${{ env.BASE_BRANCH }} --to-ref=HEAD --hook-stage=manual
 
-      - name: Python Linter
-        run: python3 -m ruff check test
-        shell: bash
+    - name: pre-commit checks (full)
+      uses: pre-commit/action@v3.0.1
+      env:
+        SKIP: golangci-lint-diff
+      with:
+        extra_args: --all-files --hook-stage=manual
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -9,17 +9,17 @@ repos:
       - id: trailing-whitespace
       - id: end-of-file-fixer
       - id: check-yaml
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         # Ignore some Yaml's with following pattern in `testdata` subdirectories.
         exclude: testdata/.*?(?:invalid|bad|broken|wrong)[^/]*\.ya?ml$
       - id: check-merge-conflict
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
       - id: no-commit-to-branch
         stages: [pre-commit]
         args: [--branch, master, --pattern, release/.*]
       - id: file-contents-sorter
         name: "Sort cspell dictionary"
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         files: ".cspell_project-words.txt"
         args: [--ignore-case, --unique]
 
@@ -28,7 +28,7 @@ repos:
     hooks:
       - id: codespell
         name: "Check for common misspellings"
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         types_or: [go, python, lua]
         additional_dependencies:
           - tomli
@@ -38,7 +38,7 @@ repos:
     hooks:
       - id: cspell
         name: "Spell-checking documentation files"
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         args:
           [--config=.cspell-precommit.json, --show-context, --show-suggestions]
         types_or: [markdown]
@@ -71,7 +71,7 @@ repos:
         language: golang
         types: [go]
         name: "Go: formatting sources"
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         exclude: \.pb\.go$
         entry: bash -c "GOFUMPT_SPLIT_LONG_LINES=on gofumpt $@"
         args: [-e, -w, -extra]
@@ -83,7 +83,7 @@ repos:
     hooks:
       - id: golines
         name: "Go: shorten long lines"
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         exclude: \.pb\.go$
         args: [--max-len=100, --tab-len=4, --no-reformat-tags]
 
@@ -100,31 +100,48 @@ repos:
         args: [--fast-only, --config=golint-precommit.yml]
 
       - id: golangci-lint-full
-        name: &qu
10000
ot;Go: full verify sources"
-        description: "Command to run: `pre-commit run --hook-stage manual golangci-lint-full`"
+        name: "Go: verify all sources (CI)"
+        description: Checking all Go sources.
+        pass_filenames: false
+        always_run: true
         stages: [manual]
-        args: [--config=golint-precommit.yml]
+        args: [--config=golint-precommit-ci.yml, --allow-parallel-runners]
 
-  - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.11.11
+  - repo: local
     hooks:
-      - id: ruff-format
-        name: "Py: Run the formatter"
-        stages: [pre-commit]
-        files: test/.*\.py$
+      - id: golangci-lint-diff
+        language: golang
+        types: [go]
+        name: "Go: verify sources diff (CI)"
+        stages: [manual]
+        pass_filenames: false
+        always_run: true
+        entry: >-
+          bash -c "golangci-lint run --new-from-rev=${BASE_BRANCH:-master}
+          --config=golint-precommit.yml --allow-parallel-runners"
+        additional_dependencies:
+          - github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6
 
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.12.0
+    hooks:
       - id: ruff-check
         name: "Py: Run the linter"
         args: [--fix]
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
+        files: test/.*\.py$
+
+      - id: ruff-format
+        name: "Py: Run the formatter"
+        stages: [pre-commit, manual]
         files: test/.*\.py$
 
   - repo: https://github.com/DavidAnson/markdownlint-cli2
     rev: v0.18.1
     hooks:
       - id: markdownlint-cli2
         name: "MD: check markdown files"
-        stages: [pre-commit]
+        stages: [pre-commit, manual]
         # TODO: configure the rules and fix the rest of the .md files (#TNTP-3107).
         files: CHANGELOG.md
         args: [--fix]

diff --git a/cli/binary/list.go b/cli/binary/list.go
@@ -43,6 +43,7 @@ func ParseBinaries(fileList []fs.DirEntry, program search.Program,
 	if fileInfo, err := os.Lstat(programPath); err == nil {
 		if program == search.ProgramDev &&
 			fileInfo.Mode()&os.ModeSymlink == os.ModeSymlink {
+
 			binActive, isTarantoolBinary, err := install.IsTarantoolDev(programPath, binDir)
 			if err != nil {
 				return binaryVersions, err
@@ -91,7 +92,6 @@ func ParseBinaries(fileList []fs.DirEntry, program search.Program,
 				ver.Str = versionStr
 			}
 			binaryVersions = append(binaryVersions, ver)
-
 		}
 	}
 
@@ -130,7 +130,6 @@ func ListBinaries(cmdCtx *cmdcontext.CmdCtx, cliOpts *config.CliOpts) (err error
 				printVersion(binVersion.Str)
 			}
 		}
-
 	}
 
 	return err

diff --git a/cli/binary/switch.go b/cli/binary/switch.go
@@ -86,9 +86,7 @@ func ChooseVersion(binDir string, program search.Program) (string, error) {
 	}
 	_, version, err := versionSelect.Run()
 	version = cleanString(version)
-	if strings.HasSuffix(version, " [active]") {
-		version = strings.TrimSuffix(version, " [active]")
-	}
+	version = strings.TrimSuffix(version, " [active]")
 
 	return version, err
 }

diff --git a/cli/cmd/aeon.go b/cli/cmd/aeon.go
@@ -140,6 +140,7 @@ func aeonConnectValidateArgs(cmd *cobra.Command, args []string) error {
 
 	if !cmd.Flags().Changed("transport") && (connectCtx.Ssl.KeyFile != "" ||
 		connectCtx.Ssl.CertFile != "" || connectCtx.Ssl.CaFile != "") {
+
 		connectCtx.Transport = aeoncmd.TransportSsl
 	}
 

diff --git a/cli/cmd/cluster.go b/cli/cmd/cluster.go
@@ -497,13 +497,13 @@ func internalClusterReplicasetRolesRemoveModule(cmdCtx *cmdcontext.CmdCtx, args
 	return clustercmd.ChangeRole(args[0], rolesChangeCtx, replicaset.RolesRemover{})
 }
 
-// internalClusterFailoverSwitchModule is as "cluster failover switch" command
+// internalClusterFailoverSwitchModule is as "cluster failover switch" command.
 func internalClusterFailoverSwitchModule(cmdCtx *cmdcontext.CmdCtx, args []string) error {
 	switchCtx.InstName = args[1]
 	return clustercmd.Switch(args[0], switchCtx)
 }
 
-// internalClusterFailoverSwitchStatusModule is as "cluster failover switch-status" command
+// internalClusterFailoverSwitchStatusModule is as "cluster failover switch-status" command.
 func internalClusterFailoverSwitchStatusModule(cmdCtx *cmdcontext.CmdCtx, args []string) error {
 	switchStatusCtx.TaskID = args[1]
 	return clustercmd.SwitchStatus(args[0], switchStatusCtx)
@@ -560,8 +560,9 @@ func checkRolesChangeFlags(isAdd bool) error {
 	if !isAdd {
 		action = "removed"
 	}
-	if rolesChangeCtx.IsGlobal == false && rolesChangeCtx.GroupName == "" &&
+	if !rolesChangeCtx.IsGlobal && rolesChangeCtx.GroupName == "" &&
 		rolesChangeCtx.ReplicasetName == "" && rolesChangeCtx.InstName == "" {
+
 		return util.NewArgError(fmt.Sprintf("need to provide flag(s) with scope roles will %s",
 			action))
 	}

diff --git a/cli/cmd/completion.go b/cli/cmd/completion.go
@@ -72,7 +72,6 @@ func injectRocksCompletion(shell string, completion []byte) ([]byte, error) {
 		res.WriteString("\n")
 		res.Write(injection)
 		res.Write(rocks)
-
 	} else {
 		label := []byte(`    # The user could have moved the cursor backwards on the command-line.`)
 		idx := bytes.Index(completion, label)

diff --git a/cli/cmd/connect.go b/cli/cmd/connect.go
@@ -138,12 +138,12 @@ func resolveConnectOpts(cmdCtx *cmdcontext.CmdCtx, cliOpts *config.CliOpts,
 	if fillErr == nil {
 		if len(runningCtx.Instances) > 1 {
 			err = fmt.Errorf("specify instance name")
-			return
+			return connOpts, err
 		}
 		if (connectCtx.Username != "" || connectCtx.Password != "") && !connectCtx.Binary {
 			err = fmt.Errorf("username and password are not supported" +
 				" with a connection via a control socket")
-			return
+			return connOpts, err
 		}
 		if connectCtx.Binary {
 			connOpts = makeConnOpts(
@@ -158,7 +158,7 @@ func resolveConnectOpts(cmdCtx *cmdcontext.CmdCtx, cliOpts *config.CliOpts,
 		if connectCtx.Username != "" || connectCtx.Password != "" {
 			err = fmt.Errorf("username and password are specified with" +
 				" flags and a URI")
-			return
+			return connOpts, err
 		}
 		newURI, user, pass := libconnect.ParseCredentialsURI(target)
 		network, address := libconnect.ParseBaseURI(newURI)
@@ -178,12 +178,12 @@ func resolveConnectOpts(cmdCtx *cmdcontext.CmdCtx, cliOpts *config.CliOpts,
 		connOpts = makeConnOpts(network, address, *connectCtx)
 	} else {
 		err = fillErr
-		return
+		return connOpts, err
 	}
 	if connectCtx.ConnectTarget == "" {
 		connectCtx.ConnectTarget = target
 	}
-	return
+	return connOpts, err
 }
 
 // internalConnectModule is a default connect module.

diff --git a/cli/cmd/internal/completion.go b/cli/cmd/internal/completion.go
@@ -28,14 +28,14 @@ func ValidArgsFunction(
 	var runningCtx running.RunningCtx
 	err := running.FillCtx(cliOpts, cmdCtx, &runningCtx, nil, running.ConfigLoadSkip)
 	if err != nil {
-		return
+		return args, directive
 	}
 
 	if strings.ContainsRune(toComplete, running.InstanceDelimiter) {
 		args = instPicker(runningCtx.Instances)
-		return
+		return args, directive
 	}
 
 	args = appPicker(runningCtx.Instances)
-	return
+	return args, directive
 }
diff --git a/cli/cmd/kill.go b/cli/cmd/kill.go
@@ -44,7 +44,7 @@ func NewKillCmd() *cobra.Command {
 
 func askConfirmation(args []string) (bool, error) {
 	var err error
-	var confirm bool = true
+	confirm := true
 	if !forceKill {
 		confirmationMsg := "Kill all instances?"
 		if len(args) > 0 {

diff --git a/cli/cmd/pack.go b/cli/cmd/pack.go
@@ -125,7 +125,7 @@ func checkFlags(packCtx *pack.PackCtx) error {
 				" but you are not packaging RPM or DEB. Flag will be ignored")
 		}
 	case pack.Rpm, pack.Deb:
-		if packCtx.Archive.All == true {
+		if packCtx.Archive.All {
 			log.Warnf("You specified the --all flag," +
 				" but you are not packaging a tarball. Flag will be ignored")
 		}

diff --git a/cli/cmd/play.go b/cli/cmd/play.go
@@ -178,6 +178,7 @@ func internalPlayModule(cmdCtx *cmdcontext.CmdCtx, args []string) error {
 	}
 	if playSslCertFile != "" || playSslKeyFile != "" ||
 		playSslCaFile != "" || playSslCiphers != "" {
+
 		os.Setenv("TT_CLI_PLAY_TRANSPORT", "ssl")
 	}
 

diff --git a/cli/cmd/replicaset.go b/cli/cmd/replicaset.go
@@ -790,10 +790,12 @@ func internalReplicasetRolesAddModule(cmdCtx *cmdcontext.CmdCtx, args []string)
 	defer ctx.Conn.Close()
 	if ctx.IsApplication && replicasetInstanceName == "" && ctx.InstName == "" &&
 		!replicasetIsGlobal && replicasetGroupName == "" && replicasetReplicasetName == "" {
+
 		return fmt.Errorf("there is no destination provided in which to add role")
 	}
 	if ctx.InstName != "" && replicasetInstanceName != "" &&
 		replicasetInstanceName != ctx.InstName {
+
 		return fmt.Errorf("there are different instance names passed after" +
 			" app name and in flag arg")
 	}
@@ -833,10 +835,12 @@ func internalReplicasetRolesRemoveModule(cmdCtx *cmdcontext.CmdCtx, args []strin
 	defer ctx.Conn.Close()
 	if ctx.IsApplication && replicasetInstanceName == "" && ctx.InstName == "" &&
 		!replicasetIsGlobal && replicasetGroupName == "" && replicasetReplicasetName == "" {
+
 		return fmt.Errorf("there is no destination provided where to remove role")
 	}
 	if ctx.InstName != "" && replicasetInstanceName != "" &&
 		replicasetInstanceName != ctx.InstName {
+
 		return fmt.Errorf("there are different instance names passed after" +
 			" app name and in flag arg")
 	}

diff --git a/cli/cmd/stop.go b/cli/cmd/stop.go
@@ -42,7 +42,7 @@ func internalStopWithConfirmationModule(cmdCtx *cmdcontext.CmdCtx, args []string
 		return errNoConfig
 	}
 
-	if !(autoYes || cmdCtx.Cli.NoPrompt) {
+	if !autoYes && !cmdCtx.Cli.NoPrompt {
 		instancesToConfirm := ""
 		if len(args) == 0 {
 			instancesToConfirm = "all instances"
@@ -74,7 +74,7 @@ func internalStopModule(cmdCtx *cmdcontext.CmdCtx, args []string) error {
 	}
 
 	var runningCtx running.RunningCtx
-	var err error = running.FillCtx(cliOpts, cmdCtx, &runningCtx, args, running.ConfigLoadSkip)
+	err := running.FillCtx(cliOpts, cmdCtx, &runningCtx, args, running.ConfigLoadSkip)
 	if err != nil {
 		return err
 	}

diff --git a/cli/codegen/generate_code.go b/cli/codegen/generate_code.go
@@ -64,7 +64,7 @@ func generateLuaCodeVar() error {
 // generateFileModeFile generates
 // var FileModes = map[string]int {
 // "filename": filemode,
-// }
+// }.
 func generateFileModeFile(path, filename, varNamePrefix string) error {
 	goFile := jen.NewFile("static")
 	goFile.Comment("This file is generated! DO NOT EDIT\n")