8000 Deprecate invalid labels by yngvar-antonsson · Pull Request #1980 · tarantool/cartridge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecate invalid labels #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 18, 2022
Merged

Deprecate invalid labels #1980

merged 5 commits into from
Nov 18, 2022

Conversation

yngvar-antonsson
Copy link
Contributor
@yngvar-antonsson yngvar-antonsson commented Nov 17, 2022 •
edited
Loading

Deprecation of invalid labels usage.
Before this PR, there were rules on how to use labels, but no validation was performed.
Now invalid labels will produce an error message in logs. In the next releases usage of invalid labels will return an error on edit_topology call. Make sure that your labels are valid.

Valid labels:

  • type string
  • not exceed 63 character
  • contain only alphanumerics [a-zA-Z], dots (.) and underscores (_)
  • not start and end with dot (.)

Examples of invalid labels:

["label"] = box.NULL}
["label"] = 1}
["label"] = true}
{["label"] = {}}
{["label."] = "1234"}
{["io..tarantool"] = "1234"}
{["io.tarantool/vshard"] = "1234"}

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Close #1977

@yngvar-antonsson yngvar-antonsson marked this pull request as draft November 17, 2022 14:33
@yngvar-antonsson yngvar-antonsson changed the title Allow to use box.NULL as label value Deprecate invalid labels Nov 18, 2022
@yngvar-antonsson yngvar-antonsson marked this pull request as ready for review November 18, 2022 12:44
@yngvar-antonsson yngvar-antonsson merged commit 70255c5 into master Nov 18, 2022
@yngvar-antonsson yngvar-antonsson deleted the nullable-labels branch November 18, 2022 14:06
@yngvar-antonsson yngvar-antonsson mentioned this pull request Mar 21, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filonenko-mikhail filonenko-mikhail filonenko-mikhail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate config doesn't actually check labels
2 participants
@yngvar-antonsson @filonenko-mikhail
0