8000 expirationd doesn't process tasks with zero length `box.cfg.replication` · Issue #95 · tarantool/expirationd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

expirationd doesn't process tasks with zero length box.cfg.replication #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artemreyt opened this issue Nov 8, 2021 · 1 comment
Closed

expirationd doesn't process tasks with zero length box.cfg.replication #95

artemreyt opened this issue Nov 8, 2021 · 1 comment
Assignees
@oleg-jukovec
Labels
bug Something isn't working

Comments

@artemreyt
Copy link
artemreyt commented Nov 8, 2021 •
edited
Loading

Documentation says "by default expirationd should process tasks only on the writeable instance, it means that expirationd will not start task processing on a replica. Here the word 'replica' means an instance with at least one configured upstream".

But if to create an instance like:

box.cfg{
    replication = {};
    read_only = false,
}

Expirationd doesn't process tasks. But it has no configured upstream in real.

If it's really a bug, it seems to be because of this line (box.cfg.replication actually not nil):

expirationd/expirationd.lua

Line 151 in 176e713

if (box.cfg.replication_source == nil and box.cfg.replication == nil) or task.force then

Of course option force of expirationd.start() can help at this case, but In my opinion the word force you should use only where it is really needed :)
@artemreyt artemreyt changed the title expirationd doesn't process tasks with zero length box.cfg.repliction expirationd doesn't process tasks with zero length box.cfg.replication Nov 8, 2021
@ArtDu
Copy link
Contributor
ArtDu commented Nov 9, 2021

also related to #92

@kyukhin kyukhin added the teamE label Dec 3, 2021
@Totktonada Totktonada added 1sp bug Something isn't working labels Mar 23, 2022
oleg-jukovec added a commit that referenced this issue May 30, 2022
@oleg-jukovec
Fix processing tasks with zero length box.cfg.replication
7e8cad3 
Closes #95
@oleg-jukovec oleg-jukovec mentioned this issue May 30, 2022
Merged
oleg-jukovec added a commit that referenced this issue May 31, 2022
@oleg-jukovec
Fix processing tasks with zero length box.cfg.replication
408d828 
Closes #95
oleg-jukovec added a commit that referenced this issue May 31, 2022
@oleg-jukovec
Fix processing tasks with zero length box.cfg.replication
63274bb 
Closes #95
oleg-jukovec added a commit that referenced this issue Jun 9, 2022
@oleg-jukovec
Fix processing tasks with zero length box.cfg.replication
29db52b 
Closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Totktonada @kyukhin @ArtDu @oleg-jukovec @artemreyt
0