8000 Fix flaky testcase by ligurio · Pull Request #97 · tarantool/expirationd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix flaky testcase #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix flaky testcase #97

merged 1 commit into from
Nov 12, 2021

Conversation

ligurio
Copy link
Member
@ligurio ligurio commented Nov 11, 2021

suite: simple expires test
testcase: Test task executed and moved to archive

Fixes #90

@ligurio ligurio force-pushed the ligurio/gh-90-fix-flaky-test branch 3 times, most recently from 10f3f6a to da5138c Compare November 11, 2021 14:27
Sometimes check for task.expired_tuples_count failed because not all
tuples were archived. With wait_cond() test become more reliable.

Fixes #90
@ligurio ligurio force-pushed the ligurio/gh-90-fix-flaky-test branch from da5138c to b73ea59 Compare November 11, 2021 14:32
@ligurio ligurio requested a review from olegrok November 11, 2021 17:50
@ligurio
Copy link
Member Author
ligurio commented Nov 12, 2021

5 test workflow restarts without failed testcases,
https://github.com/tarantool/expirationd/actions/runs/1449203699

@ligurio ligurio merged commit 77370ba into master Nov 12, 2021
@ligurio ligurio deleted the ligurio/gh-90-fix-flaky-test branch November 12, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAP testcase 'simple expires test' sometimes failed (flaky?)
2 participants
0