travis-ci: fix tarantool repository enabling #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, download.tarantool.org may use redirects, so curl -L (--location) should be used. At least now it redirects from http to https when we ask for a gpg key. In future it may redirect to another backend. Next, added -s (--silent, don't show a progress meter), -S (--show-error, show an error message on stderr), -f (--fail, no output to stdout at error) for curl, because curl command is part of a shell pipeline and this way the next pipeline command will not receive an unexpected data like 404 Not found HTML page. While I'm here, I changed all URLs to https, because those http URLs anyway redirect to https.
|
Looks OK for me. |
romanhabibov
approved these changes
Mar 1, 2021
|
Thanks! Please, rebase PR #55 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, download.tarantool.org may use redirects, so curl -L (--location)
should be used. At least now it redirects from http to https when we ask
for a gpg key. In future it may redirect to another backend.
Next, added -s (--silent, don't show a progress meter), -S
(--show-error, show an error message on stderr), -f (--fail, no output
to stdout at error) for curl, because curl command is part of a shell
pipeline and this way the next pipeline command will not receive an
unexpected data like 404 Not found HTML page.
While I'm here, I changed all URLs to https, because those http URLs
anyway redirect to https.