8000 heap-buffer-overflow write in HTMLlineproc2body() · Issue #61 · tats/w3m · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

heap-buffer-overflow write in HTMLlineproc2body() #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kcwu opened this issue Dec 2, 2016 · 2 comments
Closed

heap-buffer-overflow write in HTMLlineproc2body() #61

kcwu opened this issue Dec 2, 2016 · 2 comments

Comments

@kcwu
Copy link
Contributor
kcwu commented Dec 2, 2016 •
edited
Loading

input (xxd cases/tats-w3m-61)

00000000: 3c62 7574 746f 6e20 7661 6c75 653d 2722  <button value='"
00000010: 3e3c 4120 6872 6566 3d3e 3c2f 613e 273e  ><A href=></a>'>
00000020: 303c 703e                                0<p>

how to reproduce:

ASAN_OPTIONS=abort_on_error=1:detect_leaks=0 LD_LIBRARY_PATH=./notgc ./w3m-tats.asan -T text/html -dump cases/tats-w3m-61

stderr:

=================================================================
==3694512==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61300000dafc at pc 0x00000059bcff bp 0x7fffbc8c7af0 sp 0x7fffbc8c7ae8
WRITE of size 4 at 0x61300000dafc thread T0
    #0 0x59bcfe in HTMLlineproc2body /targets/w3m-tats/file.c:5731:49
    #1 0x59702e in HTMLlineproc2 /targets/w3m-tats/file.c:6198:5
    #2 0x5a63ee in loadHTMLstream /targets/w3m-tats/file.c:7289:5
    #3 0x55bbf8 in loadHTMLBuffer /targets/w3m-tats/file.c:6781:5
    #4 0x55ee64 in loadSomething /targets/w3m-tats/file.c:224:16
    #5 0x5535ac in loadGeneralFile /targets/w3m-tats/file.c:2241:6
    #6 0x4f9202 in main /targets/w3m-tats/main.c:1017:12
    #7 0x7f3a4ea10f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287
    #8 0x41bf25 in _start (/w3m-tats.asan+0x41bf25)

0x61300000dafc is located 4 bytes to the left of 360-byte region [0x61300000db00,0x61300000dc68)
allocated by thread T0 here:
    #0 0x4c6288 in __interceptor_malloc (/w3m-tats.asan+0x4c6288)
    #1 0x7f3a5015ec21 in GC_malloc_atomic /notgc/notgc.c:275
    #2 0x59c7cc in HTMLlineproc2body /targets/w3m-tats/file.c:5845:5
    #3 0x59702e in HTMLlineproc2 /targets/w3m-tats/file.c:6198:5
    #4 0x5a63ee in loadHTMLstream /targets/w3m-tats/file.c:7289:5
    #5 0x55bbf8 in loadHTMLBuffer /targets/w3m-tats/file.c:6781:5
    #6 0x55ee64 in loadSomething /targets/w3m-tats/file.c:224:16
    #7 0x5535ac in loadGeneralFile /targets/w3m-tats/file.c:2241:6
    #8 0x4f9202 in main /targets/w3m-tats/main.c:1017:12
    #9 0x7f3a4ea10f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: heap-buffer-overflow /targets/w3m-tats/file.c:5731:49 in HTMLlineproc2body
Shadow bytes around the buggy address:
  0x0c267fff9b00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fff9b10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fff9b20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fff9b30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fff9b40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c267fff9b50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa[fa]
  0x0c267fff9b60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fff9b70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fff9b80: 00 00 00 00 00 00 00 00 00 00 00 00 00 fa fa fa
  0x0c267fff9b90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c267fff9ba0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==3694512==ABORTING

This is detected with help of dummy libgc wrapper. See http://github.com/kcwu/fuzzing-w3m/notgc for detail.
More detail to reproduce please see http://github.com/kcwu/fuzzing-w3m

For your convenience,
gdbline:
LD_LIBRARY_PATH=./notgc ASAN_OPTIONS=abort_on_error=1:detect_leaks=0 gdb --args ./w3m-tats.asan -T text/html -dump cases/tats-w3m-61

This is found by afl-fuzz.
@kcwu
Copy link
Contributor Author
kcwu commented Dec 3, 2016 
#6  0x000000000059bcff in HTMLlineproc2body (buf=0x61500000fd00, feed=0x5b3910 <textlist_feed>, llimit=-1) at file.c:5731
5731                                    buf->hmarklist->marks[a_href->hseq].invalid = 1;
(gdb) p a_href->hseq
$1 = -1

tats added a commit that referenced this issue Dec 5, 2016
@tats
Prevent negative array index for marks in HTMLlineproc2body()
f34c 8000 37f 
Bug-Debian: #61
@tats
Copy link
Owner
tats commented Dec 5, 2016

Fixed, thank you.

@tats tats closed this as completed Dec 5, 2016
tats added a commit that referenced this issue May 5, 2017
@tats
Fix multiple vulnerabilities (closes: #850432)
d73f74e 
- New patch 934_menu.patch to fix buffer overflow (#49)
- New patch 935_shiftanchor.patch to fix buffer overflow (#62)
- New patch 936_metarefresh.patch to fix buffer overflow (#63)
- New patch 937_lineproc0.patch to fix buffer overflow (#67)
- New patch 938_lineproc2body.patch to fix buffer overflow (#61)
- New patch 939_textarea.patch to fix buffer overflow (#58)
- New patch 940_tabattr.patch to fix buffer overflow (#60)
- New patch 941_integeredwidth.patch to fix buffer overflow (#70)
- New patch 942_tridvalue.patch to fix buffer overflow (#71)
- New patch 943_pushlink.patch to fix buffer overflow (#64, #66)
- New patch 944_lineproc0.patch to fix use after free (#65)
- New patch 945_wtfstrwidth.patch to fix buffer overflow (#57)
- New patch 946_strnewsize.patch to fix buffer overflow (#72)
- New patch 947_realcolumn.patch to fix buffer overflow (#69)
- New patch 948_getmclen.patch to fix buffer overflow
  (#59, #73, #74, #75, #76, #78, #79, #80, #83, #84)
- New patch 949_wtftowcs.patch to fix buffer overflow (#77)
- New patch 950_textarea.patch to fix infinite loop (#85)
- New patch 951_lineproc0.patch to fix use after free (#81)
- New patch 952_formupdatebuffer.patch to fix buffer overflow (#82)
- New patch 953_formupdateline.patch to fix buffer overflow
  (#68#issuecomment-266214643)
- New patch 954_wtfparse1.patch to fix buffer overflow (#68)
tats added a commit that referenced this issue May 5, 2017
@tats
Prevent negative array index for marks in HTMLlineproc2body()
f16c128 
Bug-Debian: #61
Origin: https://anonscm.debian.org/cgit/collab-maint/w3m.git/commit/?id=f34c37f3156d1578a53dccc582c83c88fff76f87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kcwu @tats
0