refactor: simplify future in command IPC structs
#13529
Conversation
Package Changes Through 3570d80There are 8 changes which include tauri-bundler with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/cli with minor, tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
I think so too |
|
from ~3.2 to ~2.9 on macos (battery saving mode, forgot to say that in the last pr) - only a single command in my test project tho |
|
you may want to wait for @lucasfernog to chime in cause i have no clue why there was a impl Future instead of an async fn in the first place. |
|
Or maybe not 😂 |
|
Let's just merge it and see anything breaks 🙃 I guess it was probably for supporting prior rust editions without |
Reference: #13382
This reduced the incremental compilation time from 4.36s to 3.59s on my machine quite consistently (tested by adding and removing a new line inside an async command)
I don't fully understand the differences between an async function vs
impl Futurein rust though, but I think they're the same in this case