-
Notifications
You must be signed in to change notification settings - Fork 43
Density Matrix Purification Solvers with optional GPU acceleration #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pitsteinbach
wants to merge
37
commits into
tblite:main
Choose a base branch
from
pitsteinbach:tc-purification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,966
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 70.65% 70.38% -0.27%
==========================================
Files 159 163 +4
Lines 20058 20241 +183
Branches 7133 7212 +79
==========================================
+ Hits 14172 14247 +75
- Misses 2267 2344 +77
- Partials 3619 3650 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I want to introduce DMP solvers implemented in our
GAMBITS
library totblite
. Additionally, acuSOLVER´-based DSYGVD solver is also added.
GAMBITS` depends on LAHVA which provides a BLAS LAPACK interface with easy switching between CPU and GPU based execution.In general we would need to discuss how our CD/CI can test for GPU builds.
There are also a few changes in this PR that affect the solver type, those are mainly needed when interfacing
tblite
to CREST or another program based on MD simulations where we would like to have a solver that can exist for multiple singlepoint calculations. Additional work, will also be needed inCREST
but that is also prepared.Further details about the method and it's implementation can be found here: https://chemrxiv.org/engage/chemrxiv/article-details/678e35ecfa469535b9c804c4
ToDos: