Speedup path lookup by avoiding object allocation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Request#resource` relies on `URI#full_path` to combine both `path` and `query` elements of the parsed URI in order to construct another string. By doing that, a few temporary strings are allocated, adding elements for the GC to collect. That combined with the Regex introduces a slowdown in the lookup, not to mention the call to PCRE (C land). `URI` already provides `path` clean from query parameters and that is exposed as part of the request as `path`. You can see the performance differences on the following benchmark: https://gist.github.com/luislavena/2bbb6befb8c0dd5ea3c7a628aba3d39d Results: URI#path: 423.36M ( 2.36ns) (± 1.61%) fastest URI#full_path + Regex: 3.44M ( 290.8ns) (± 0.51%) 123.11× slower
|
This is an awesome commit! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request#resourcerelies onURI#full_pathto combine bothpathandqueryelements of the parsed URI in order to construct another string.By doing that, a few temporary strings are allocated, adding elements for the GC to collect.
That combined with the Regex introduces a slowdown in the lookup, not to mention the call to PCRE (C land).
URIalready providespathclean from query parameters and that is exposed as part of the request aspath.You can see the performance differences on the following benchmark:
https://gist.github.com/luislavena/2bbb6befb8c0dd5ea3c7a628aba3d39d
Results:
Thank you. ❤️ ❤️ ❤️