8000 feat: return 404 if path not found by vladfaust · Pull Request #14 · tbrand/router.cr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: return 404 if path not found #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2017
Merged

feat: return 404 if path not found #14

merged 1 commit into from
Jul 19, 2017

Conversation

vladfaust
Copy link
Contributor

Fixes #13

tbrand
tbrand approved these changes Jul 19, 2017
View reviewed changes
Copy link
Owner
@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@tbrand tbrand merged commit 94e8ef3 into tbrand:master Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrand tbrand tbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladfaust @tbrand
0