add new keyboard shortcut to jump to the most recent link target #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
commented
Apr 29, 2025
| this.selectPin((e.keyCode - 9) % 10); | ||
| } else if (e.key === '`') { | ||
| if (document.location.hash) { | ||
| document.querySelector(document.location.hash).scrollIntoView(true); |
There was a problem hiding this comment.
This could also be done with document.location = document.location, but that felt gross to me.
bakkot
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
`as a new keyboard shortcut to jump to the last place you jumped. I like to think of it as a kind of "dynamic pin". When I click a link to somewhere in the spec, I often scroll or Ctrl-F my way away without thinking of pinning it and want a quick way to get back to what I was just looking at. I chose`for the key because it nicely aligns with the numbered pins on my keyboard and the above-stated mental model as another pin. Also, it's the same key used to jump to a mark in vim.