8000 Migrate `BlocklistRecord`s and `Background` persistence from Hive to `drift` by SleepySquash · Pull Request #1018 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate BlocklistRecords and Background persistence from Hive to drift #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2024
Merged

Migrate BlocklistRecords and Background persistence from Hive to drift #1018

merged 2 commits into from
Jun 3, 2024

Conversation

SleepySquash
Copy link
Contributor
@SleepySquash SleepySquash commented Jun 3, 2024 •
edited
Loading

Part of #27

Synopsis

Hive is obsolete.

Solution

This PR:

  • migrates BlocklistRecords to drift;
  • migrates Background to drift.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Jun 3, 2024
@SleepySquash SleepySquash added this to the 0.1.0-alpha.14 milestone Jun 3, 2024
@SleepySquash SleepySquash self-assigned this Jun 3, 2024
@SleepySquash
Copy link
Contributor Author

FCM

Migrate `BlocklistRecord`s and `Background` persistence from Hive to `drift` (#1018)

- impl `Background` and `Blocklist` tables and conversion methods for them
- refactor `SettingsRepository` to use `BackgroundDriftProvider`
- rename `HiveBackground` to `DtoBackground`
- rename `HiveBlocklistRecord` to `DtoBlocklistRecord`
- remove `BackgroundHiveProvider`, `BlocklistHiveProvider` and `BlocklistSortingHiveProvider`

Additionally:
- add `RegExp` validation to `BlocklistReason` scalar
- fix possible "transaction is closed" errors in `RxChatImpl`
- upgrade `medea_jason` to its latest version

@SleepySquash SleepySquash marked this pull request as ready for review June 3, 2024 12:05
@SleepySquash SleepySquash merged commit b738bd1 into main Jun 3, 2024
24 checks passed
8000
@SleepySquash SleepySquash deleted the migrate-other-to-drift branch June 3, 2024 12:07
github-actions bot added a commit that referenced this pull request Jun 3, 2024
@github-actions
Migrate BlocklistRecords and Background persistence from Hive to …
99bcc4c 
…`drift` (#1018)

- impl `Background` and `Blocklist` tables and conversion methods for them
- refactor `SettingsRepository` to use `BackgroundDriftProvider`
- rename `HiveBackground` to `DtoBackground`
- rename `HiveBlocklistRecord` to `DtoBlocklistRecord`
- remove `BackgroundHiveProvider`, `BlocklistHiveProvider` and `BlocklistSortingHiveProvider`

Additionally:
- add `RegExp` validation to `BlocklistReason` scalar
- fix possible "transaction is closed" errors in `RxChatImpl`
- upgrade `medea_jason` to its latest version b738bd1
@SleepySquash SleepySquash mentioned this pull request Jun 3, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash
0